Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion about save names #602

Open
K14Mua opened this issue Apr 29, 2024 · 4 comments
Open

Confusion about save names #602

K14Mua opened this issue Apr 29, 2024 · 4 comments

Comments

@K14Mua
Copy link

K14Mua commented Apr 29, 2024

Good day, I have a question about cantilever arches.

Each chapter is divided into days in chapter jumps. And after some days, a menu opens to save and view new tips. If it is saved in this place, then the chapter number will be written in the list of saves in the text field under the save. And these numbers are mixed up

image

For example, Taraimawashi has 2 tips.

  1. At the end of the first save it says End of Chapter 1
  2. At the end of the second End of Chapter 9

There are no hints at all in Tsukiotoshi

image

There are 5 hints in Someutsushi

  1. End of Chapter 3
  2. End of Chapter 6
  3. End of Chapter 7
  4. End of Chapter 9
  5. End of Chapter 14

image

In Kageboshi - 7.

  1. End of Chapter 1
  2. End of Chapter 2
  3. End of Chapter 3
  4. End of Chapter 4
  5. End of Chapter 7
  6. End of Chapter 11
  7. End of Chapter 12

image

I haven't read further yet

So, is it possible to somehow change this text? In Taraimawashi, for example, do this

  • Taraimawashi: End of Chapter 1
  • Taraimawashi: End of Chapter 2

In Kageboshi:

  • Kageboshi: End of Chapter 1
  • Kageboshi: End of Chapter 2
  • Kageboshi: End of Chapter 3
  • Kageboshi: End of Chapter 4
  • Kageboshi: End of Chapter 5
  • Kageboshi: End of Chapter 6
  • Kageboshi: End of Chapter 7

So the title of the chapter and the serial number of the hint would be written in the save. Or add intermediate save and hint menus after each part of the chapter, even if no new half-tales have appeared.

@drojf
Copy link
Contributor

drojf commented Apr 30, 2024

Hi, normally @DoctorDiablo handles the console stuff, but I looked into it. However I don't really know how the script is supposed to work.

The issue seems to be that in chapterselect.txt, there is some confusion between "days" and "chapters".

For example, see the below code snipped for Kageboshi (click to expand):

void KageDay4()
{
if (ModGetHighestChapterFlag(3)<3)
ModSetHighestChapterFlag(3, 3);
CallScript( "kage_004" );
SetLocalFlag(LConsoleArc, 3);
StoreValueToLocalWork( ChapterNumber, 4 );
SavePoint("Ch.4 終わり", "End of Chapter 4");
CallSection( "SetDay" );
CallSection( "ViewTips" );
JumpSection("KageDay5");
}
void KageDay5()
{
if (ModGetHighestChapterFlag(3)<4)
ModSetHighestChapterFlag(3, 4);
CallScript( "kage_005" );
JumpSection("KageDay6");
}
void KageDay6()
{
if (ModGetHighestChapterFlag(3)<5)
ModSetHighestChapterFlag(3, 5);
CallScript( "kage_006" );
JumpSection("KageDay7");
}
void KageDay7()
{
if (ModGetHighestChapterFlag(3)<6)
ModSetHighestChapterFlag(3, 6);
CallScript( "kage_007" );
SetLocalFlag(LConsoleArc, 3);
StoreValueToLocalWork( ChapterNumber, 7 );
SavePoint("Ch.7 終わり", "End of Chapter 7");
CallSection( "SetDay" );
CallSection( "ViewTips" );
JumpSection("KageDay8");
}

You'll note that day 4 has the line SavePoint("Ch.4 終わり", "End of Chapter 4"); . But day 5 and day 6 are missing this function. Then day 7 has SavePoint("Ch.7 終わり", "End of Chapter 7"); .


So to fix it according to your post, you could go through all the SavePoint() functions and re-number them. For example, in the above void KageDay7(), change SavePoint("Ch.7 終わり", "End of Chapter 7"); to SavePoint("Ch.5 終わり", "End of Chapter 5");

But I'm not sure if the correct way to fix it is to add a SavePoint() for every day, if 1 day = 1 chapter. So you would just go through every day and add a SavePoint("Ch.[DAY_NUMBER] 終わり", "End of Chapter [DAY_NUMBER]"); , replacing [DAY_NUMBER] with the day number.


@DoctorDiablo Do you know what is the correct way to fix this?

@DoctorDiablo
Copy link
Member

The chapter numbers we use come from the console version. They get used in the Chapter Jump screen to allow you to skip to any chapter you've read. We shouldn't change the text on those labels because it would make the numbers inconsistent with Chapter Jump.

We could add a save point at the end of every chapter, but I worry that might get annoying. The main series almost always shows that screen with new tips, so it might feel weird if it showed up all the time with no new tips.

Think it might be better to just leave this one the way it is.

@K14Mua
Copy link
Author

K14Mua commented Apr 30, 2024

That is, you are not surprised that after the 1st chapter comes the 9th chapter and then the 1st again? This creates a huge amount of confusion in saves. Which save is from which chapter? What is their correct order? Why is everything so confusing?

When I read chapters, if I need to pause, I try to do it at some logical pause. When a fragment of a chapter ends and the save menu is displayed, it makes it clear that I can save here and interrupt. In the very first chapter, the first fragment ends very quickly, and then the game goes on and on, on and on, on and on, and offers to save at the very end. I didn't plan on playing through the entire chapter in one go, but the game didn't offer any time to take a break.

@drojf
Copy link
Contributor

drojf commented Apr 30, 2024

We could add a save point at the end of every chapter, but I worry that might get annoying. The main series almost always shows that screen with new tips, so it might feel weird if it showed up all the time with no new tip

I mean, we could just update the save marker (call SavePoint()) without showing the save screen? Then it's up to the user to save whenever they like, and the save names would be sequential.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants