perf: add benchmarks for different components #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crate: trace_decoder
Nashtare
commented
Jun 11, 2024
| @@ -106,7 +106,7 @@ global mpt_read_extension_not_found: | |||
| // Not found; return 0. | |||
| %stack (key_part, future_nibbles, key, node_payload_ptr, retdest) -> (retdest, 0) | |||
| JUMP | |||
| mpt_read_extension_found: | |||
| global mpt_read_extension_found: | |||
There was a problem hiding this comment.
This and below have been added while debugging the fibonacci test, as we would otherwise have mpt_read_extension_not_found (i.e. the label above) to pop in the logs while we did find the extension, which is extremely confusing.
hratoanina
reviewed
Jun 12, 2024
hratoanina
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few benchmarks in order to track the impact of future changes / refactoring on some parts of the codebase. Namely: