refactor(api): remove NUMBER_OF_CHALLENGES_FOR_FLASH_METHOD env variable

Author: alexandrecoin

api/sample.env

@@ -691,9 +691,6 @@ ENABLE_KNEX_PERFORMANCE_MONITORING=false
 # FLASH METHOD CHALLENGES
 # ========
 
-# Number of challenges given to the user during a flash test.
-NUMBER_OF_CHALLENGES_FOR_FLASH_METHOD=48
-
 # Success probability threshold used to compute the minimum capability
 # to succeed on a challenge
 SUCCESS_PROBABILITY_THRESHOLD=0.95

api/src/shared/config.js

@@ -278,7 +278,6 @@ const configuration = (function () {
       garAccessV2: toBoolean(process.env.GAR_ACCESS_V2),
       maxReachableLevel: _getNumber(process.env.MAX_REACHABLE_LEVEL, 5),
       newYearOrganizationLearnersImportDate: _getDate(process.env.NEW_YEAR_ORGANIZATION_LEARNERS_IMPORT_DATE),
-      numberOfChallengesForFlashMethod: _getNumber(process.env.NUMBER_OF_CHALLENGES_FOR_FLASH_METHOD),
       successProbabilityThreshold: parseFloat(process.env.SUCCESS_PROBABILITY_THRESHOLD ?? '0.95'),
       pixCertifScoBlockedAccessDateLycee: process.env.PIX_CERTIF_SCO_BLOCKED_ACCESS_DATE_LYCEE,
       pixCertifScoBlockedAccessDateCollege: process.env.PIX_CERTIF_SCO_BLOCKED_ACCESS_DATE_COLLEGE,
@@ -507,7 +506,6 @@ const configuration = (function () {
     config.features.dayBeforeCompetenceResetV2 = 7;
     config.features.garAccessV2 = false;
     config.features.maxReachableLevel = 5;
-    config.features.numberOfChallengesForFlashMethod = 10;
     config.features.pixCertifScoBlockedAccessDateLycee = null;
     config.features.pixCertifScoBlockedAccessDateCollege = null;
 

api/tests/certification/shared/unit/domain/models/FlashAssessmentAlgorithm_test.js

@@ -92,7 +92,6 @@ describe('Unit | Domain | Models | FlashAssessmentAlgorithm | FlashAssessmentAlg
           const remainingAnswersToGive = 1;
           const initialCapacity = config.v3Certification.defaultCandidateCapacity;
           const computedCapacity = 2;
-          config.features.numberOfChallengesForFlashMethod = 20;
           const algorithm = new FlashAssessmentAlgorithm({
             flashAlgorithmImplementation,
             configuration: _getAlgorithmConfig({
@@ -166,7 +165,6 @@ describe('Unit | Domain | Models | FlashAssessmentAlgorithm | FlashAssessmentAlg
           const remainingAnswersToGive = 1;
           const initialCapacity = config.v3Certification.defaultCandidateCapacity;
           const computedCapacity = 2;
-          config.features.numberOfChallengesForFlashMethod = 20;
           const algorithm = new FlashAssessmentAlgorithm({
             flashAlgorithmImplementation,
             configuration: _getAlgorithmConfig({

docker/sample.env

@@ -661,9 +661,6 @@ ENABLE_KNEX_PERFORMANCE_MONITORING=false
 # FLASH METHOD CHALLENGES
 # ========
 
-# Number of challenges given to the user during a flash test.
-NUMBER_OF_CHALLENGES_FOR_FLASH_METHOD=48
-
 # Success probability threshold used to compute the minimum capability
 # to succeed on a challenge
 SUCCESS_PROBABILITY_THRESHOLD=0.95