fix(certif): fix lint issues

HEYGUL · HEYGUL · commit 8566bcda32a0 · 2025-03-13T18:20:50.000+01:00
diff --git a/certif/app/components/issue-report-modal/add-issue-report-modal.js b/certif/app/components/issue-report-modal/add-issue-report-modal.js
@@ -194,7 +194,7 @@ export default class AddIssueReportModal extends Component {
     try {
       await issueReportToSave.save();
       this.args.closeModal();
-    } catch (err) {
+    } catch {
       issueReportToSave.rollbackAttributes();
       this.showIssueReportSubmitError = true;
     }
diff --git a/certif/app/components/issue-report-modal/issue-reports-modal.js b/certif/app/components/issue-report-modal/issue-reports-modal.js
@@ -10,7 +10,7 @@ export default class IssueReportsModal extends Component {
     this.showDeletionError = false;
     try {
       await this.args.onClickDeleteIssueReport(issueReport);
-    } catch (err) {
+    } catch {
       this.showDeletionError = true;
     }
   }
diff --git a/certif/app/components/members-list.js b/certif/app/components/members-list.js
@@ -59,7 +59,7 @@ export default class MembersList extends Component {
       });
       await this.session.waitBeforeInvalidation(5000);
       this.session.invalidate();
-    } catch (error) {
+    } catch {
       this.pixToast.sendErrorNotification({
         message: this.intl.t('pages.team.members.notifications.leave-certification-center.error'),
       });
@@ -78,7 +78,7 @@ export default class MembersList extends Component {
           memberLastName: this.removingMember.lastName,
         }),
       });
-    } catch (e) {
+    } catch {
       this.pixToast.sendErrorNotification({
         message: this.intl.t('pages.team.members.notifications.remove-membership.error'),
       });
@@ -96,7 +96,7 @@ export default class MembersList extends Component {
         message: this.intl.t('pages.team.members.notifications.change-member-role.success'),
       });
       this.isChangeMemberRoleModalOpen = false;
-    } catch (_) {
+    } catch {
       this.member.rollbackAttributes();
       this.pixToast.sendErrorNotification({
         message: this.intl.t('pages.team.members.notifications.change-member-role.error'),
diff --git a/certif/app/components/session-supervising/candidate-in-list.js b/certif/app/components/session-supervising/candidate-in-list.js
@@ -163,7 +163,7 @@ export default class CandidateInList extends Component {
       await adapter.dismissLiveAlert(this.args.sessionId, this.args.candidate.userId);
       this.isLiveAlertValidated = false;
       this.displayedModal = Modals.HandledLiveAlertSuccess;
-    } catch (error) {
+    } catch {
       const errorMessage = this.intl.t(
         'pages.session-supervising.candidate-in-list.handle-live-alert-modal.error-handling.miscellaneous',
       );
@@ -209,7 +209,7 @@ export default class CandidateInList extends Component {
           htmlSafe: true,
         }),
       });
-    } catch (error) {
+    } catch {
       this.pixToast.sendErrorNotification({
         message: this.intl.t(
           'pages.session-supervising.candidate-in-list.handle-live-alert-modal.error-handling.miscellaneous',
@@ -265,7 +265,7 @@ export default class CandidateInList extends Component {
           lastName: this.args.candidate.lastName,
         }),
       });
-    } catch (error) {
+    } catch {
       this.pixToast.sendErrorNotification({
         message: this.intl.t('pages.session-supervising.candidate-in-list.test-end-modal.error', {
           firstName: this.args.candidate.firstName,
diff --git a/certif/app/components/sessions/session-details/enrolled-candidates/index.gjs b/certif/app/components/sessions/session-details/enrolled-candidates/index.gjs
@@ -139,7 +139,7 @@ export default class EnrolledCandidates extends Component {
         message: this.intl.t('pages.sessions.detail.candidates.edit-modal.notifications.success'),
       });
       this.closeEditCandidateModal();
-    } catch (e) {
+    } catch {
       this.pixToast.sendErrorNotification({
         message: this.intl.t('pages.sessions.detail.candidates.edit-modal.notifications.error'),
       });
diff --git a/certif/app/components/sessions/session-details/index.gjs b/certif/app/components/sessions/session-details/index.gjs
@@ -22,7 +22,7 @@ export default class SessionDetails extends Component {
     try {
       const token = this.session.data.authenticated.access_token;
       await this.fileSaver.save({ url: this.args.model.sessionManagement.urlToDownloadSupervisorKitPdf, token });
-    } catch (err) {
+    } catch {
       this.pixToast.sendErrorNotification({ message: this.intl.t('common.api-error-messages.internal-server-error') });
     }
   }
@@ -32,7 +32,7 @@ export default class SessionDetails extends Component {
     try {
       const token = this.session.data.authenticated.access_token;
       await this.fileSaver.save({ url: this.args.model.session.urlToDownloadAttendanceSheet, token });
-    } catch (err) {
+    } catch {
       this.pixToast.sendErrorNotification({ message: this.intl.t('common.api-error-messages.internal-server-error') });
     }
   }
diff --git a/certif/app/controllers/authenticated/sessions/details/certification-candidates.js b/certif/app/controllers/authenticated/sessions/details/certification-candidates.js
@@ -42,7 +42,7 @@ export default class CertificationCandidatesController extends Controller {
     try {
       const token = this.session.data.authenticated.access_token;
       await this.fileSaver.save({ url: this.model.session.urlToDownloadCandidatesImportTemplate, token });
-    } catch (err) {
+    } catch {
       this.pixToast.sendErrorNotification({ message: this.intl.t('common.api-error-messages.internal-server-error') });
     }
   }
diff --git a/certif/app/controllers/authenticated/sessions/import.js b/certif/app/controllers/authenticated/sessions/import.js
@@ -107,7 +107,7 @@ export default class ImportController extends Controller {
           candidatesCount: this.candidatesCount,
         }),
       });
-    } catch (error) {
+    } catch {
       this.isImportStepOne = true;
       this.pixToast.sendErrorNotification({ message: this.intl.t('common.api-error-messages.internal-server-error') });
     }
diff --git a/certif/app/controllers/authenticated/team/list.js b/certif/app/controllers/authenticated/team/list.js
@@ -59,7 +59,7 @@ export default class AuthenticatedTeamListController extends Controller {
         this.shouldShowRefererSelectionModal = !this.shouldShowRefererSelectionModal;
         this.send('refreshModel');
         this.pixToast.sendSuccessNotification({ message: this.intl.t('pages.team.notifications.success') });
-      } catch (responseError) {
+      } catch {
         this.pixToast.sendErrorNotification({
           message: this.intl.t('common.api-error-messages.internal-server-error'),
         });
diff --git a/certif/app/controllers/authenticated/team/list/invitations.js b/certif/app/controllers/authenticated/team/list/invitations.js
@@ -14,7 +14,7 @@ export default class AuthenticatedTeamListInvitationsController extends Controll
       this.pixToast.sendSuccessNotification({
         message: this.intl.t('pages.team-invitations.notifications.success.invitation-cancelled'),
       });
-    } catch (error) {
+    } catch {
       this.pixToast.sendErrorNotification({ message: this.intl.t('common.api-error-messages.internal-server-error') });
     }
   }
@@ -30,7 +30,7 @@ export default class AuthenticatedTeamListInvitationsController extends Controll
       this.pixToast.sendSuccessNotification({
         message: this.intl.t('pages.team-invitations.notifications.success.invitation-resent'),
       });
-    } catch (error) {
+    } catch {
       this.pixToast.sendErrorNotification({ message: this.intl.t('common.api-error-messages.internal-server-error') });
     } finally {
       setTimeout(
diff --git a/certif/app/controllers/session-supervising.js b/certif/app/controllers/session-supervising.js
@@ -30,7 +30,7 @@ export default class SessionSupervisingController extends Controller {
 
     try {
       await this.fileSaver.save({ url, token });
-    } catch (error) {
+    } catch {
       this.pixToast.sendErrorNotification({ message: this.intl.t('common.api-error-messages.internal-server-error') });
     }
   }
diff --git a/certif/app/controllers/terms-of-service.js b/certif/app/controllers/terms-of-service.js
@@ -19,7 +19,7 @@ export default class TermsOfServiceController extends Controller {
       });
       this.currentUser.certificationPointOfContact.pixCertifTermsOfServiceAccepted = true;
       this.router.transitionTo('authenticated.sessions');
-    } catch (errorResponse) {
+    } catch {
       this.pixToast.sendErrorNotification({ message: this.intl.t('common.api-error-messages.internal-server-error') });
     }
   }
diff --git a/certif/app/models/subscription.js b/certif/app/models/subscription.js
@@ -25,6 +25,6 @@ export default class SubscriptionModel extends Model {
     const matchingHabilitation = centerHabilitations.find(
       (habilitation) => habilitation.id === this.complementaryCertificationId,
     );
-    return matchingHabilitation?.key === COMPLEMENTARY_KEYS.CLEA ?? false;
+    return matchingHabilitation?.key === COMPLEMENTARY_KEYS.CLEA;
   }
 }
diff --git a/certif/app/routes/authenticated/sessions/finalize.js b/certif/app/routes/authenticated/sessions/finalize.js
@@ -20,7 +20,7 @@ export default class SessionsFinalizeRoute extends Route {
       await session.certificationReports;
 
       return session;
-    } catch (responseError) {
+    } catch {
       this.pixToast.sendErrorNotification({ message: this.intl.t('common.api-error-messages.internal-server-error') });
       this.router.transitionTo('authenticated.sessions.details', session_id);
     }
diff --git a/certif/app/services/current-user.js b/certif/app/services/current-user.js
@@ -25,7 +25,7 @@ export default class CurrentUserService extends Service {
         );
         await this._updateCurrentUserAccessToCertificationCenter();
         this.isAdminOfCurrentCertificationCenter = this.currentCertificationCenterMembership?.isAdmin;
-      } catch (error) {
+      } catch {
         this.certificationPointOfContact = null;
         this.currentAllowedCertificationCenterAccess = null;
         this.currentCertificationCenterMembership = null;
diff --git a/certif/config/environment.js b/certif/config/environment.js
@@ -137,7 +137,6 @@ module.exports = function (environment) {
   // Warn for unknown feature toggles
   _.each(process.env, (value, key) => {
     if (key.startsWith('FT_') && _.indexOf(ACTIVE_FEATURE_TOGGLES, key) === -1) {
-      // eslint-disable-next-line no-console
       console.warn(`Unknown feature toggle ${key}. Please remove it from your environment variables.`);
     }
   });
diff --git a/certif/eslint.config.mjs b/certif/eslint.config.mjs
@@ -50,6 +50,7 @@ export default [
       globals: {
         ...globals.browser,
         ...globals.node,
+        server: true,
       },
       parser: babelParser,
       parserOptions: {
diff --git a/certif/package-lock.json b/certif/package-lock.json
diff --git a/certif/package.json b/certif/package.json
diff --git a/certif/tests/unit/models/certification-issue-report-test.js b/certif/tests/unit/models/certification-issue-report-test.js
diff --git a/certif/tests/unit/routes/not-found-test.js b/certif/tests/unit/routes/not-found-test.js
diff --git a/certif/translations/en.json b/certif/translations/en.json
diff --git a/certif/translations/fr.json b/certif/translations/fr.json

Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,7 @@ export default class AddIssueReportModal extends Component {`
`194`	`194`	`try {`
`195`	`195`	`await issueReportToSave.save();`
`196`	`196`	`this.args.closeModal();`
`197`		`- } catch (err) {`
	`197`	`+ } catch {`
`198`	`198`	`issueReportToSave.rollbackAttributes();`
`199`	`199`	`this.showIssueReportSubmitError = true;`
`200`	`200`	`}`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ export default class IssueReportsModal extends Component {`
`10`	`10`	`this.showDeletionError = false;`
`11`	`11`	`try {`
`12`	`12`	`await this.args.onClickDeleteIssueReport(issueReport);`
`13`		`- } catch (err) {`
	`13`	`+ } catch {`
`14`	`14`	`this.showDeletionError = true;`
`15`	`15`	`}`
`16`	`16`	`}`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ export default class SessionDetails extends Component {`
`22`	`22`	`try {`
`23`	`23`	`const token = this.session.data.authenticated.access_token;`
`24`	`24`	`await this.fileSaver.save({ url: this.args.model.sessionManagement.urlToDownloadSupervisorKitPdf, token });`
`25`		`- } catch (err) {`
	`25`	`+ } catch {`
`26`	`26`	`this.pixToast.sendErrorNotification({ message: this.intl.t('common.api-error-messages.internal-server-error') });`
`27`	`27`	`}`
`28`	`28`	`}`
`@@ -32,7 +32,7 @@ export default class SessionDetails extends Component {`
`32`	`32`	`try {`
`33`	`33`	`const token = this.session.data.authenticated.access_token;`
`34`	`34`	`await this.fileSaver.save({ url: this.args.model.session.urlToDownloadAttendanceSheet, token });`
`35`		`- } catch (err) {`
	`35`	`+ } catch {`
`36`	`36`	`this.pixToast.sendErrorNotification({ message: this.intl.t('common.api-error-messages.internal-server-error') });`
`37`	`37`	`}`
`38`	`38`	`}`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ export default class CertificationCandidatesController extends Controller {`
`42`	`42`	`try {`
`43`	`43`	`const token = this.session.data.authenticated.access_token;`
`44`	`44`	`await this.fileSaver.save({ url: this.model.session.urlToDownloadCandidatesImportTemplate, token });`
`45`		`- } catch (err) {`
	`45`	`+ } catch {`
`46`	`46`	`this.pixToast.sendErrorNotification({ message: this.intl.t('common.api-error-messages.internal-server-error') });`
`47`	`47`	`}`
`48`	`48`	`}`
Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ export default class ImportController extends Controller {`
`107`	`107`	`candidatesCount: this.candidatesCount,`
`108`	`108`	`}),`
`109`	`109`	`});`
`110`		`- } catch (error) {`
	`110`	`+ } catch {`
`111`	`111`	`this.isImportStepOne = true;`
`112`	`112`	`this.pixToast.sendErrorNotification({ message: this.intl.t('common.api-error-messages.internal-server-error') });`
`113`	`113`	`}`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ export default class SessionSupervisingController extends Controller {`
`30`	`30`
`31`	`31`	`try {`
`32`	`32`	`await this.fileSaver.save({ url, token });`
`33`		`- } catch (error) {`
	`33`	`+ } catch {`
`34`	`34`	`this.pixToast.sendErrorNotification({ message: this.intl.t('common.api-error-messages.internal-server-error') });`
`35`	`35`	`}`
`36`	`36`	`}`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ export default class TermsOfServiceController extends Controller {`
`19`	`19`	`});`
`20`	`20`	`this.currentUser.certificationPointOfContact.pixCertifTermsOfServiceAccepted = true;`
`21`	`21`	`this.router.transitionTo('authenticated.sessions');`
`22`		`- } catch (errorResponse) {`
	`22`	`+ } catch {`
`23`	`23`	`this.pixToast.sendErrorNotification({ message: this.intl.t('common.api-error-messages.internal-server-error') });`
`24`	`24`	`}`
`25`	`25`	`}`
Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,6 @@ export default class SubscriptionModel extends Model {`
`25`	`25`	`const matchingHabilitation = centerHabilitations.find(`
`26`	`26`	`(habilitation) => habilitation.id === this.complementaryCertificationId,`
`27`	`27`	`);`
`28`		`- return matchingHabilitation?.key === COMPLEMENTARY_KEYS.CLEA ?? false;`
	`28`	`+ return matchingHabilitation?.key === COMPLEMENTARY_KEYS.CLEA;`
`29`	`29`	`}`
`30`	`30`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ export default class SessionsFinalizeRoute extends Route {`
`20`	`20`	`await session.certificationReports;`
`21`	`21`
`22`	`22`	`return session;`
`23`		`- } catch (responseError) {`
	`23`	`+ } catch {`
`24`	`24`	`this.pixToast.sendErrorNotification({ message: this.intl.t('common.api-error-messages.internal-server-error') });`
`25`	`25`	`this.router.transitionTo('authenticated.sessions.details', session_id);`
`26`	`26`	`}`
Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,6 @@ module.exports = function (environment) {`
`137`	`137`	`// Warn for unknown feature toggles`
`138`	`138`	`_.each(process.env, (value, key) => {`
`139`	`139`	`if (key.startsWith('FT_') && _.indexOf(ACTIVE_FEATURE_TOGGLES, key) === -1) {`
`140`		`- // eslint-disable-next-line no-console`
`141`	`140`	console.warn(`Unknown feature toggle ${key}. Please remove it from your environment variables.`);
`142`	`141`	`}`
`143`	`142`	`});`