Limit terminal width to parent container size #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oliverroick I've had to basically use https://xtermjs.org/docs/api/addons/fit/ in the past to deal with any sizing issues with xterm in the past. For example, in https://github.com/jupyterhub/binderhub/blob/a93a01cf620605f20d5874a02ffbf9afd9ef97b9/binderhub/static/js/index.js#L74 (don't judge the rest of the code), we call fit everytime something is written to the terminal, to deal with the second side effect I think. |
oliverroick
force-pushed
the
limit-terminal-size
branch
from
44b58a1 to
6807e96
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67
By setting the min-size of the grid cell to 0, we prevent the children from growing beyond its size.
This resolves the issue described but has size effects:
I couldn't find any xterm settings to change the behaviour so I'm not sure what the best approach is.