From d3959bd15670de60b7bfc328bda1d5c4a164404d Mon Sep 17 00:00:00 2001 From: Daniel Stockman Date: Fri, 19 Jul 2019 10:16:11 -0700 Subject: [PATCH] test(windows): Normalize paths in various assertions --- .../publish/__tests__/publish-command.test.js | 22 +++++++++++-------- core/package/__tests__/core-package.test.js | 4 ++-- 2 files changed, 15 insertions(+), 11 deletions(-) diff --git a/commands/publish/__tests__/publish-command.test.js b/commands/publish/__tests__/publish-command.test.js index 9e83fb5a07..f6238a2ce1 100644 --- a/commands/publish/__tests__/publish-command.test.js +++ b/commands/publish/__tests__/publish-command.test.js @@ -29,6 +29,7 @@ const getTwoFactorAuthRequired = require("../lib/get-two-factor-auth-required"); const commitChangeToPackage = require("@lerna-test/commit-change-to-package"); const loggingOutput = require("@lerna-test/logging-output"); const initFixture = require("@lerna-test/init-fixture")(__dirname); +const path = require("path"); // file under test const lernaPublish = require("@lerna-test/command-runner")(require("../command")); @@ -315,13 +316,16 @@ Map { await lernaPublish(cwd)("--contents", "dist"); - for (const name of ["package-1", "package-2"]) { - expect(packDirectory).toHaveBeenCalledWith( - expect.objectContaining({ name }), - expect.stringContaining(`packages/${name}/dist`), - expect.any(Object) - ); - } + expect(packDirectory).toHaveBeenCalledWith( + expect.objectContaining({ name: "package-1" }), + expect.stringContaining(path.normalize("packages/package-1/dist")), + expect.any(Object) + ); + expect(packDirectory).toHaveBeenCalledWith( + expect.objectContaining({ name: "package-2" }), + expect.stringContaining(path.normalize("packages/package-2/dist")), + expect.any(Object) + ); }); }); @@ -339,12 +343,12 @@ Map { expect(packDirectory).toHaveBeenCalledWith( expect.objectContaining({ name: "package-1" }), - expect.stringMatching(/packages\/package-1\/dist$/), + expect.stringMatching(/packages[\\/]+package-1[\\/]+dist$/), expect.any(Object) ); expect(packDirectory).toHaveBeenCalledWith( expect.objectContaining({ name: "package-2" }), - expect.stringMatching(/packages\/package-2$/), + expect.stringMatching(/packages[\\/]+package-2$/), expect.any(Object) ); }); diff --git a/core/package/__tests__/core-package.test.js b/core/package/__tests__/core-package.test.js index 266174f137..8ab747f96a 100644 --- a/core/package/__tests__/core-package.test.js +++ b/core/package/__tests__/core-package.test.js @@ -282,14 +282,14 @@ describe("Package.lazy()", () => { const pkg = Package.lazy("/foo/bar"); expect(pkg).toBeInstanceOf(Package); - expect(pkg.location).toBe("/foo/bar"); + expect(pkg.location).toMatch(path.normalize("/foo/bar")); }); it("returns package instance from package.json file argument", () => { const pkg = Package.lazy("/foo/bar/package.json"); expect(pkg).toBeInstanceOf(Package); - expect(pkg.location).toBe("/foo/bar"); + expect(pkg.location).toMatch(path.normalize("/foo/bar")); }); it("returns package instance from json and dir arguments", () => {