Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent Message map for preserve threading #1964

Closed
yousefmansy1 opened this issue Feb 11, 2023 · 1 comment
Closed

Persistent Message map for preserve threading #1964

yousefmansy1 opened this issue Feb 11, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@yousefmansy1
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Current options for preserve threading allows for platforms that support replies/threads to represent that properly
However when the bot is restarted that information is lost and therefore threads/replies are lost

Describe the solution you'd like
Using a persistent data struct store message mapping IDs that may be referenced back to for long term thread preservation.
TediCross utilizes a sqlite DB to store the data and read from long term.

For higher performance rocksdb can be considered, a fork of TediCross has implemented this, however I have not confirmed if it works or not.
TediCross/TediCross@36d016f

I took a peek at the source and a fallback can be added to FindCanonicalMsgID()

Describe alternatives you've considered
An alternative is to allow for a fallback for a text in-line reply when a message isnt found in the in-memory message map.
However, this is a much worse solution.
(Currently a reply/quote is not shown at all when threading cannot be resolved)

Additional context
After trying many chat bridges this is by far the best one. I really really appreciate and admire the effort taken in this project!

@yousefmansy1 yousefmansy1 added the enhancement New feature or request label Feb 11, 2023
@yousefmansy1
Copy link
Contributor Author

Realized this is a duplicate of #541.
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant