-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Discord reply #1706
base: master
Are you sure you want to change the base?
Support Discord reply #1706
Conversation
613cd5c
to
b147cc9
Compare
@lekoOwO we already supported discord replies. What issues do you have with the current implementation? |
Um do we have one? |
So no message appears on telegram when using reply on discord? |
Replied message appears on telegram with no reply info just like other plain messages. |
@42wim discord has changed the way it handles replies, please merge it into master. |
+1 |
just ran into this issue on a new install, looking forward to this pr merged |
Works perfectly for me. |
Yesterday tested master branch without this merge requests. Replying from discord works fine in telegram. Don't understand why we need this change then. |
@sleroq can you show us a screenshot? You might be misunderstanding what this PR does |
Without this change, a Discord user replying to someone is bridged as a normal message that's not a reply to Matrix and will have an empty reply on Telegram. This appears to work properly at least as a workaround for now. It would be really nice if matterbridge used structured replies across the bridge but perhaps it's unrealistic to expect that. |
b147cc9
to
b63eccd
Compare
Code Climate has analyzed commit b63eccd and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well and we use it in production for GrapheneOS.
@42wim This still merges cleanly and works correctly. You can reproduce the issue by replying to a message on Discord and checking how it appears on Telegram. This makes Discord replies work the same way as Telegram replies which is a nice improvement over the current status quo of it being broken. |
This is still needed. Looks like it needs a minor rebase. |
No description provided.