-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Soulseek bridge #2167
base: master
Are you sure you want to change the base?
Add Soulseek bridge #2167
Conversation
b.local <- bridgeMessage | ||
} | ||
|
||
func (b *Bsoulseek) handleLeaveMessage(msg userLeftRoomMessage) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
b.local <- bridgeMessage | ||
} | ||
|
||
func (b *Bsoulseek) handleJoinMessage(msg userJoinedRoomMessage) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
} | ||
} | ||
|
||
func (b *Bsoulseek) loginLoop() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method Bsoulseek.loginLoop
has 65 lines of code (exceeds 50 allowed). Consider refactoring.
} | ||
} | ||
|
||
func (b *Bsoulseek) loginLoop() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method Bsoulseek.loginLoop
has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
} | ||
} | ||
|
||
func (b *Bsoulseek) loginLoop() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method Bsoulseek.loginLoop
has 66 lines of code (exceeds 50 allowed). Consider refactoring.
} | ||
} | ||
|
||
func (b *Bsoulseek) loginLoop() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method Bsoulseek.loginLoop
has 68 lines of code (exceeds 50 allowed). Consider refactoring.
} | ||
} | ||
|
||
func (b *Bsoulseek) loginLoop() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method Bsoulseek.loginLoop
has 69 lines of code (exceeds 50 allowed). Consider refactoring.
Code Climate has analyzed commit 17849a5 and detected 4 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Adds a bridge to/from Soulseek chatrooms. First time using Go so code review appreciated. I haven't figured out exactly how Soulseek rate limiting works so some messages might not get sent/the bridge account may get banned...
Features: