Onboard Manual #379
Onboard Manual #379
Conversation
main/display/display.c
Outdated
| */ | ||
| void drawChar(display_t* disp, paletteColor_t color, int h, const font_ch_t* ch, int16_t xOff, int16_t yOff) | ||
| void drawCharItalic(display_t* disp, paletteColor_t color, int h, const font_ch_t* ch, int16_t xOff, int16_t yOff, int8_t slant) |
There was a problem hiding this comment.
Also organizationally, I think there's enough text function stuff here to get broken out into it's own file.
There was a problem hiding this comment.
Yeah, display.c has accumulated an awful lot of non-display things. Can move some things to font.c or something.
There was a problem hiding this comment.
I need to impose a "no more than 1k lines" rule or something... MISRA compliance?
There was a problem hiding this comment.
Is this a mandatory change for this PR to be accepted? I may be able to make spare cycles to do it
| { | ||
| switch (evt->button) | ||
| { | ||
| case UP: |
There was a problem hiding this comment.
What's the point of chapters if you can only navigate page by page?
There was a problem hiding this comment.
That's what I was trying to add most recently, but I was doing it in a dumb way and didn't quite have time to finish after I started doing it in a not-dumb way.
|
Have you coordinated with thaeli about this? |
Brycey92
force-pushed
the
onboard-manual-take-2
branch
from
57a5247 to
072dc2b
Compare
I talked to thaeli earlier today, and I got her raw Google form submission csv, so I can make a rough pass at slapping that into markdown formatting tomorrow |
|
Not ready for merge as-is. Newlines are broken, as are horizontal rules. In my testing, the issue persisted before my and Max's changes at 072dc2b, and at db710d8, before merging Oddly, I went back to each commit on December 6, when dylwhich was showing me those features working, but they were broken on those commits too. It's possible this is an issue on my dev environment, or that dylwhich has uncommitted changes. Can anyone confirm or deny these issues? Working display for reference |
|
I don't have enough time to review and test something this large before magfest, and the actual manual entries aren't written yet, so this is not gonna make the 1.1 cut. I'll leave the PR though. It's definitely something worth fiddling with for next year, though perhaps in a simpler manner. |
dylwhich
force-pushed
the
onboard-manual-take-2
branch
from
289a82f to
1e3af76
Compare
No description provided.