-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
broken with Xcode 11.0 beta 1? #87
Comments
An issue is happening at the PHLivePhotoPlus class.
Can anyone support us with this issue?
|
same issue here too... Anyone solve it? |
don't inherit PHLivePhoto. Author intent to write a packet of PHLivePhoto class. Thats totally the wrong way. ❌ 🤔 // this is a PHLivePhoto 🤔
let livePhotoPlus: PHLivePhotoPlus
// this is also a PHLivePhoto 😡😡😡
livePhotoPlus.livePhoto ❌@objc public class PHLivePhotoPlus: PHLivePhoto {
internal var pairedVideoPath:URL?
internal var keyPhotoPath:URL?
/// A `PHLivePhoto` object that returns the Live Photo content from `PHLivePhotoPlus`.
@objc public var livePhoto:PHLivePhoto?
@objc public override init() {
super.init()
}
@objc public init(photo:PHLivePhoto) {
super.init()
livePhoto = photo
}
...
} SHOULD BE LIKE THIS@objc public class PHLivePhotoPlus: NSObject {
internal var pairedVideoPath:URL?
internal var keyPhotoPath:URL?
/// A `PHLivePhoto` object that returns the Live Photo content from `PHLivePhotoPlus`.
@objc public var livePhoto: PHLivePhoto?
@objc public override init() {
super.init()
}
@objc public init(photo: PHLivePhoto) {
super.init()
livePhoto = photo
}
...
} #94 PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: