Add clone and eq in prefix_cache value #1267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyanpeng-google
requested review from
gobbleturk,
khatwanimohit,
bvandermoon,
vipannalla and
RissyRan
as code owners
yuyanpeng-google
force-pushed
the
yuyan-prefix-cache-trie
branch
from
81a33fb to
470da2f
Compare
Clone to prevent use the same jax array. TESTED=unittest
yuyanpeng-google
force-pushed
the
yuyan-prefix-cache-value-clone
branch
from
f5d898b to
fd3b786
Compare
|
#1278 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #1266
Clone to prevent use the same jax array.
TESTED=unittest
FIXES: b/389788256
Checklist
Before submitting this PR, please make sure (put X in square brackets):