fp8 quantization for inference. #1316
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwyang-google
requested review from
gobbleturk,
khatwanimohit,
bvandermoon,
vipannalla,
RissyRan,
richjames0,
rni418 and
gagika
as code owners
|
Important The terms of service for this installation has not been accepted. Please ask the Organization owners to visit the Gemini Code Assist Admin Console to sign it. |
|
@singh-mitali, can you take a look at these quantization changes? |
jwyang-google
force-pushed
the
gpu_inference_quant
branch
from
a0ec1b6 to
061b9da
Compare
jwyang-google
force-pushed
the
gpu_inference_quant
branch
from
061b9da to
a681ba3
Compare
| @@ -496,6 +521,8 @@ def einsum_fn_with_rhs_qtensor( | |||
| def einsum_fn_with_rhs_qtensor_and_dequant(self, value): | |||
| return self.einsum_fn_with_rhs_qtensor( | |||
| value, | |||
| lhs_dequant_mode=aqt_config.DequantMode.THIS_INPUT, | |||
There was a problem hiding this comment.
Why was this change required?
There was a problem hiding this comment.
Adding this would make it perform better with fp8. int8 performance stays the same.
There was a problem hiding this comment.
Can we make this a separate function or pass a flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Start with a short description of what the PR does and how this is a change from
the past.
The rest of the description includes relevant details and context, examples:
If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456
Notice 1 Once all tests pass, the "pull ready" label will automatically be assigned. This label is used
for administrative purposes. Please do not add it manually.
Notice 2 For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.
Tests
Please describe how you tested this change, and include any instructions and/or
commands to reproduce.
Checklist
Before submitting this PR, please make sure (put X in square brackets):