Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review theming capabilities of the frontend and create example for docs #151

Open
t-muehlberger opened this issue Sep 28, 2023 · 6 comments
Assignees
Labels
area:frontend Related to the UI component prio:B Major impact, but not essential type:enhancement New feature or request

Comments

@t-muehlberger
Copy link
Collaborator

Add a parameter that allows loading an additional CSS file that allows overriding existing CSS-Variables and Rules.

@t-muehlberger t-muehlberger added type:enhancement New feature or request area:frontend Related to the UI component labels Sep 28, 2023
@jbethune
Copy link
Collaborator

Where would this parameter be configured?

@jbethune
Copy link
Collaborator

jbethune commented Oct 3, 2023

@t-muehlberger Shouldn't this be part of the 4.0 milestone? Or do you have a particular use for this in mind for the chatcontrol campaign?

@socialhack
Copy link
Member

It could very well be that some of the CSAR campaigns need or would want this to embed our tool in their websites.

@t-muehlberger
Copy link
Collaborator Author

@jbethune The scope of this task (simply loading one more css file) should be quite simple and quick to implement and might be beneficial for some campaigns, this is why it is part of the earlier milestone.

@t-muehlberger t-muehlberger self-assigned this Oct 17, 2023
@t-muehlberger t-muehlberger changed the title Enable theming in the frontend Review theming capabilities of the frontend and create example for docs Nov 26, 2024
@t-muehlberger
Copy link
Collaborator Author

t-muehlberger commented Nov 26, 2024

During the work on the frontend documentation, I noticed that, while we built the stylesheets with theming in mind, we never really tested the theming capabilities of the client. I think we should try to override some styles and also create an example of how to embed DearMEP with a custom theme.

TODOs:

  • Try overriding some CSS Custom Properties in an embedded version of DearMEP
  • Add example to documentation

@scy scy added the prio:B Major impact, but not essential label Dec 15, 2024
@scy scy removed this from the 4.0: public release milestone Dec 27, 2024
@t-muehlberger
Copy link
Collaborator Author

Thank you, @scy, for removing this issue from the milestone. As we discussed, this feels more like a documentation task and doesn’t need to block the release.

While working on this, I experimented with creating a custom theme for DearMEP and used those insights to enhance the documentation in #309.

The theming experience works for many scenarios, though it could be more streamlined. Specifically, I couldn’t find a way to customize the Angular Material 2 theme solely with CSS custom properties without an SCSS build. While this adds some complexity, the important thing is that customization is possible. I’m hopeful that future updates will improve the process.

Switching to Angular Material 3 might help, as it introduces changes to the theming system that could address some of these limitations. However, this would require further investigation, and it’s worth noting that such a change would also visually alter the appearance of DearMEP.

Alternatively, we could explore creating scripts to simplify the process of building and applying a custom theme using the current approach.

I am still unsure if we want to close this issue now and create a new issue once the need for more advanced theming arises in the future. Or maybe we should keep it open just to keep track of possible enhancemants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend Related to the UI component prio:B Major impact, but not essential type:enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants