Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make route in elks configurable in all places #186

Open
iameru opened this issue Oct 16, 2023 · 0 comments
Open

Make route in elks configurable in all places #186

iameru opened this issue Oct 16, 2023 · 0 comments
Labels
area:backend Related to the server component prio:C Nice to have, but optional state:postponed Deemed low priority type:bug Something isn't working

Comments

@iameru
Copy link
Collaborator

iameru commented Oct 16, 2023

I make this issue to remind us of refactoring the code later to make this work:

As we mount the Elks router via function and all calls concerning the config need to be in there but the start_elks_call function needs to be outside of this mount function we currently have the elks endpoint string (think {base_url}/{elks} hardcoded.

see this discussion for context

Hint for later: We could clean up the elks routers alltogether and refactor all of this in a class. We might be able to load the functions differently, avoiding the 4 kilometer deep indenting at some parts of the code.

@iameru iameru added state:postponed Deemed low priority area:backend Related to the server component labels Oct 16, 2023
@scy scy added type:bug Something isn't working prio:C Nice to have, but optional labels Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:backend Related to the server component prio:C Nice to have, but optional state:postponed Deemed low priority type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants