Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache concatenated audio #190

Open
scy opened this issue Oct 17, 2023 · 0 comments
Open

Cache concatenated audio #190

scy opened this issue Oct 17, 2023 · 0 comments
Labels
area:backend Related to the server component class:newcomer Good for newcomers to the project: easy and/or limited scope flag:caveat Might be confusing or cause problems for third-party users prio:B Major impact, but not essential type:bug Something isn't working

Comments

@scy
Copy link
Collaborator

scy commented Oct 17, 2023

As 46elks refuses to accept streaming Vorbis files, the (upcoming) IVR code ensures that concatenated IVR files will not be deleted automatically. However, since they’re essentially temporary files as far as the concatenation code is concerned, they have random, non-deterministic names and a new one will be created on each request, even if it’s for the same medialist ID. This means

  • unnecessary work to concatenate the files when a cached copy could be used
  • and (worse): they will clog up the disk at some point.

Short-term solution is to remove these files every now and then.

Long-term solution is to make sure that these files use the medialist ID in their name so that they won’t be recreated for every request.

Make sure that you don’t run into race conditions when two clients request the same ID at the same time.

@scy scy added type:bug Something isn't working area:backend Related to the server component prio:B Major impact, but not essential labels Oct 17, 2023
@scy scy removed this from the 2.1: improvements to instant calling milestone Dec 15, 2024
@scy scy added the class:newcomer Good for newcomers to the project: easy and/or limited scope label Dec 15, 2024
@scy scy added this to the 4.0: public release milestone Dec 15, 2024
@scy scy added the flag:caveat Might be confusing or cause problems for third-party users label Dec 15, 2024
@scy scy removed this from the 4.0: public release milestone Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:backend Related to the server component class:newcomer Good for newcomers to the project: easy and/or limited scope flag:caveat Might be confusing or cause problems for third-party users prio:B Major impact, but not essential type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant