Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove test.mmdb, generate it on the fly #287

Open
scy opened this issue Dec 13, 2024 · 0 comments
Open

Remove test.mmdb, generate it on the fly #287

scy opened this issue Dec 13, 2024 · 0 comments
Labels
area:backend Related to the server component class:newcomer Good for newcomers to the project: easy and/or limited scope flag:security Impacts the overall security of the system prio:C Nice to have, but optional type:enhancement New feature or request

Comments

@scy
Copy link
Collaborator

scy commented Dec 13, 2024

After what happened with the XZ Utils backdoor, I don't want to have binary test data in the repo anymore.

Running server/tests/geo_ip/create_test_db.py to create the test.mmdb file (for testing geo IP lookups) takes only about 50 ms. It should be done on the fly when setting up the tests, instead of having the generated file in the repo.
@scy scy added type:enhancement New feature or request area:backend Related to the server component class:newcomer Good for newcomers to the project: easy and/or limited scope flag:security Impacts the overall security of the system prio:C Nice to have, but optional labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:backend Related to the server component class:newcomer Good for newcomers to the project: easy and/or limited scope flag:security Impacts the overall security of the system prio:C Nice to have, but optional type:enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scy