Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback form/SMS #37

Open
scy opened this issue May 10, 2023 · 3 comments
Open

Feedback form/SMS #37

scy opened this issue May 10, 2023 · 3 comments
Assignees
Labels
area:backend Related to the server component flag:caveat Might be confusing or cause problems for third-party users prio:B Major impact, but not essential type:enhancement New feature or request type:spec Issue specifies design or behavior

Comments

@scy
Copy link
Collaborator

scy commented May 10, 2023

  • Send a feedback token SMS both for Scheduled and for Instant Calls. The rationale is that even if you start the Direct Call sitting in front of your computer, you might close the tab or walk away. Or you might start it on your phone and lose track of the open tab.
  • Feedback SMS are only sent if the connection to the Destination was successful, and the call with the Destination was longer than a configurable amount of seconds.
  • The SMS will be sent a configurable number of seconds after the call ends.
  • The SMS should include the name of the Destination you spoke with.
  • The token in the link expires after a week (configurable). This gives you a lot of time to write your feedback, but not so much time that you’ve already forgotten everything anyway.
  • Only one token per call.
  • Once you’ve submitted feedback, the token is invalidated. You cannot give feedback twice using the same token, nor can you edit your feedback.
  • The frontend can request information about a token. If the token has already been used, only this fact will be returned. If it has not, the Destination’s information is also returned. This allows the frontend to display the name & portrait, and also helps stop the User from entering feedback, only to then have it rejected because of the token being invalid.
@scy scy added the type:enhancement New feature or request label May 10, 2023
@scy scy self-assigned this May 10, 2023
@scy scy added this to the 2.0: instant call support milestone Jul 10, 2023
@scy scy added the area:backend Related to the server component label Jul 27, 2023
@scy scy changed the title Feedback SMS requirements Feedback form/SMS requirements Sep 28, 2023
@scy
Copy link
Collaborator Author

scy commented Sep 28, 2023

Added requirements discussed in today’s meeting.

@scy
Copy link
Collaborator Author

scy commented Oct 4, 2023

#164 implements the frontend endpoints as well as the database model(s).

To create a new feedback token, do a call like

create_feedback_token(
    session,
    user=UserPhone("+491751234567"),
    destination_id="96750",
    language=Language("de"),
)

The language should be the language the user requested to have the call in (even if that language is not available as audio). It allows the frontend to initialize the feedback form to that language, for example if the User opens it on their phone, where they’ve never visited the DearMEP frontend on.

👀 @iameru

@scy scy added type:documentation Improvements or additions to documentation type:spec Issue specifies design or behavior and removed type:documentation Improvements or additions to documentation type:enhancement New feature or request labels Oct 11, 2023
@scy scy changed the title Feedback form/SMS requirements Feedback form/SMS Dec 15, 2024
@scy
Copy link
Collaborator Author

scy commented Dec 15, 2024

Note that this is only partially implemented: We are able to collect instant feedback via the frontend when the user starts their call from there. However, we don't send feedback SMS and wouldn't have an URL to send users to anyway (see #150).

@scy scy added type:enhancement New feature or request prio:B Major impact, but not essential flag:caveat Might be confusing or cause problems for third-party users labels Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:backend Related to the server component flag:caveat Might be confusing or cause problems for third-party users prio:B Major impact, but not essential type:enhancement New feature or request type:spec Issue specifies design or behavior
Projects
None yet
Development

No branches or pull requests

1 participant