From 243a5f2d268d25d53109d5790182f4059760d923 Mon Sep 17 00:00:00 2001 From: Michael Zingale Date: Thu, 13 Feb 2025 12:59:27 -0500 Subject: [PATCH] update hip action -- ubuntu 20.04 runner is going away (#1750) this syncs the dependency script up with amrex --- .../dependencies/dependencies_hip.sh | 20 ++++++++++--------- .github/workflows/hip.yml | 4 ++-- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/.github/workflows/dependencies/dependencies_hip.sh b/.github/workflows/dependencies/dependencies_hip.sh index 527379e7e8..76a2abd04c 100755 --- a/.github/workflows/dependencies/dependencies_hip.sh +++ b/.github/workflows/dependencies/dependencies_hip.sh @@ -33,7 +33,9 @@ sudo apt-key add rocm.gpg.key source /etc/os-release # set UBUNTU_CODENAME: focal or jammy or ... -echo "deb [arch=amd64] https://repo.radeon.com/rocm/apt/${1-latest} ${UBUNTU_CODENAME} main" \ +VERSION=${1-6.3.2} + +echo "deb [arch=amd64] https://repo.radeon.com/rocm/apt/${VERSION} ${UBUNTU_CODENAME} main" \ | sudo tee /etc/apt/sources.list.d/rocm.list echo 'export PATH=/opt/rocm/llvm/bin:/opt/rocm/bin:/opt/rocm/profiler/bin:/opt/rocm/opencl/bin:$PATH' \ | sudo tee -a /etc/profile.d/rocm.sh @@ -53,16 +55,16 @@ sudo apt-get install -y --no-install-recommends \ libnuma-dev \ libopenmpi-dev \ openmpi-bin \ - rocm-dev \ - roctracer-dev \ - rocprofiler-dev \ - rocrand-dev \ - rocfft-dev \ - rocprim-dev \ - rocsparse-dev + rocm-dev${VERSION} \ + roctracer-dev${VERSION} \ + rocprofiler-dev${VERSION} \ + rocrand-dev${VERSION} \ + rocfft-dev${VERSION} \ + rocprim-dev${VERSION} \ + rocsparse-dev${VERSION} # hiprand-dev is a new package that does not exist in old versions -sudo apt-get install -y --no-install-recommends hiprand-dev || true +sudo apt-get install -y --no-install-recommends hiprand-dev${VERSION} || true # activate # diff --git a/.github/workflows/hip.yml b/.github/workflows/hip.yml index cd3fac813e..fff66f72ec 100644 --- a/.github/workflows/hip.yml +++ b/.github/workflows/hip.yml @@ -8,7 +8,7 @@ concurrency: jobs: hip-compile: - runs-on: ubuntu-20.04 + runs-on: ubuntu-24.04 steps: - uses: actions/checkout@v4 with: @@ -27,7 +27,7 @@ jobs: cd ../.. - name: Dependencies - run: .github/workflows/dependencies/dependencies_hip.sh + run: .github/workflows/dependencies/dependencies_hip.sh 6.3.2 - name: compile test_react with HIP (iso7) run: |