Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relocation names listing contains space (harder for CTRL+F) #308

Open
marxin opened this issue Feb 14, 2025 · 1 comment · May be fixed by #310
Open

Relocation names listing contains space (harder for CTRL+F) #308

marxin opened this issue Feb 14, 2025 · 1 comment · May be fixed by #310

Comments

@marxin
Copy link

marxin commented Feb 14, 2025

Some of the relocations contain a space in the name which makes it harder to find in the document:

R\_<CLS>\_TLSGD\_ ADR\_PREL21
                 ^---- this space
smithp35 added a commit to smithp35/abi-aa that referenced this issue Feb 17, 2025
@smithp35
[AAELF64] Remove spaces in Relocation codes
7e2d595 
A number of relocation codes such as R\_<CLS>\_TLSGD\_ ADR\_PREL21
have a space in the name after an _. These look to have been here
since the initial rst commit. It is possible that this was inherited
from the MS Word originals.

Enforce consistency be removing all the spaces.

Fixes ARM-software#308
@smithp35 smithp35 linked a pull request Feb 17, 2025 that will close this issue
Open
@smithp35
Copy link
Contributor

Thanks for the report. I've submitted a PR to remove the spaces.

These have been present since the initial commit, which was a translation from a word document. It is possible that they could have been there to influence table formatting, but I think it would be better to be consistent in the rst for the benefit of searches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[AAELF64] Remove spaces in Relocation codes smithp35/abi-aa
2 participants
@marxin @smithp35