Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uv2csolution executes cbuild setup twice #200

Open
ReinhardKeil opened this issue Feb 4, 2025 · 5 comments
Open

uv2csolution executes cbuild setup twice #200

ReinhardKeil opened this issue Feb 4, 2025 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@ReinhardKeil
Copy link
Collaborator

Execute uv2csolution using context menu in Explorer View runs cbuild setup twice.

Use this project: test.zip

uv2csolution.exe c:\Test\Jan10\10872\test.uvprojx
1 out of 1 target(s) converted
Created solution: C:/Test/Jan10/10872/test.csolution.yml
With projects:
- C:/Test/Jan10/10872/test.cproject.yml
Enqueue: cbuild setup c:\Test\Jan10\10872\test.csolution.yml --context-set --packs
Execute: cbuild setup c:\Test\Jan10\10872\test.csolution.yml --context-set --packs
C:/Test/Jan10/10872/test.csolution.yml:2:3 - error csolution: schema check failed, verify syntax

Completed: cbuild failed with exit code 1
Enqueue: cbuild setup c:\Test\Jan10\10872\test.csolution.yml --context-set --packs --update-rte
Execute: cbuild setup c:\Test\Jan10\10872\test.csolution.yml --context-set --packs --update-rte
C:/Test/Jan10/10872/test.csolution.yml:2:3 - error csolution: schema check failed, verify syntax

Completed: cbuild failed with exit code 1
@ReinhardKeil ReinhardKeil added the enhancement New feature or request label Feb 4, 2025
@JonatanAntoni JonatanAntoni moved this from Backlog to In progress in CMSIS Solution Extension Feb 6, 2025
@JonatanAntoni
Copy link
Member

JonatanAntoni commented Feb 6, 2025

Cannot reproduce.
Whats the reason behind the error message

C:/Test/Jan10/10872/test.csolution.yml:2:3 - error csolution: schema check failed, verify syntax

Another observation we need to clarify:

uv2csolution --version
uv2csolution version 1.5.0 (C) 2022-2024 Arm Ltd.

Creates two set of files for Target_1 and Target1.

@JonatanAntoni JonatanAntoni moved this from In progress to Backlog in CMSIS Solution Extension Feb 6, 2025
@JonatanAntoni
Copy link
Member

@mguzmanm, could you have a look into this UV project and if the conversion results are as expected, please?

@ReinhardKeil
Copy link
Collaborator Author

@JonatanAntoni @mguzmanm we verify this again once the uv2csolution is final. The problem is that the internal test versions set "version" to "unknown".

@jkrech
Copy link
Collaborator

jkrech commented Feb 20, 2025

I am still able to reproduce that cbuild setup is invoked twice (on windows) even with a uv2csolution 1.6.0 / 1.6.0-RC1.
This needs further investigation. As it does not create any damage I am rescheduling to next release.

@ReinhardKeil
Copy link
Collaborator Author

The reason why uv2csolution is triggered twice is that initially there is no *.cbuild-set.yml file. I would argue that generating the *.cbuild-set.yml file by cbuild itself should not trigger another cbuild run.

I did start the conversion by using the context menu in the Explorer view. This has the following issues:

  • As the user does not get feedback, I clicked the option twice. This caused the 2 times execution of uv2csolution. When no tools are loaded (and on my slow computer) it takes a while until the conversion is completed. This caused confusion on my end.
  • There is also no notification that the *.csolution.yml file exists already. This means that modifications are potentially overwritten.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

3 participants