-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NotificationConfig permission to edit only own needs account-id placeholder in permission/ability system #2847
Closed
sleidig opened this issue
Feb 11, 2025
· 2 comments
· Fixed by Aam-Digital/replication-backend#171 or #2848
Closed
NotificationConfig permission to edit only own needs account-id placeholder in permission/ability system #2847
sleidig opened this issue
Feb 11, 2025
· 2 comments
· Fixed by Aam-Digital/replication-backend#171 or #2848
Milestone
Comments
32 tasks
The default permissions should be:
|
Merged
Merged
@tomwwinter , could you review the two PRs (replication-backend + frontend) for this? |
sleidig
added a commit
to Aam-Digital/replication-backend
that referenced
this issue
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
original issue:
After further investigation, the change detection works correctly but there can be problems due to permissions: The user needs to have "manage" permission on the own
NotificationConfig
entity. If that is not given, then the config cannot be synced and the system will remain in state without "activated" notifications.For privacy and data management, each user should only have access to the own NotificationConfig entity (i.e. the doc where
"conditions": { "_id": { "$eq": "${user.id}" } }
). However, while we do have a placeholder for${user.name}
that reference the current user's linked profile entityId, we currently do not have the account (keycloak) ID available on the replication-backend's ability implementation yet.https://github.com/Aam-Digital/replication-backend/blob/1090b71d0409596483a762c8a0965a327259ace9/src/auth/guards/jwt-cookie/jwt-cookie-strategy.service.ts#L30-L40
(and also
JwtBearerStrategyService
--> centralize and re-use code to map token toUserInfo
object?)The text was updated successfully, but these errors were encountered: