Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin values are not properly localized when spliting imports #192

Open
shavounet opened this issue May 31, 2018 · 1 comment
Open

Admin values are not properly localized when spliting imports #192

shavounet opened this issue May 31, 2018 · 1 comment

Comments

@shavounet
Copy link
Contributor

We use Pimgento on a website with a lot of locales (~30) and due to #97 we split the import into several smaller ones (3 by 3)

Due to lines shown below, this implies that the last import will set admin values (which could provoke an incorrect local, see my comment in #37).

if (!isset($values[0][$columnPrefix])) {
$values[0][$columnPrefix] = $column;
}

I've overridden the method to delete those lines, which import perfectly fine, even in creation (assuming admin values are part of one of my imports).

@Melleschepers
Copy link

"Fix" doesn't work for global attributes. (non-scopable & non-localizable attributes in akeneo)... these attributes simply don't get insert/updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants