Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove netstat debugging #126

Merged
merged 2 commits into from
Apr 19, 2024
+23 −4
Merged

chore: remove netstat debugging #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd88be2
ci: widen slack-github-action version for Node 20 compat
turadg Mar 19, 2024
1a0becb
fix: wait for agd to stop if it's running
turadg Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/notify-status/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ runs:
from: ${{ inputs.from }}
- name: Send GitHub trigger payload
id: slack
uses: slackapi/slack-github-action@v1.24.0
uses: slackapi/slack-github-action@v1
with:
payload: |
{
Expand Down
25 changes: 22 additions & 3 deletions packages/synthetic-chain/public/upgrade-test-scripts/env_setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,31 @@ if [[ "$binary" == "agd" ]]; then
sed -i 's/minSubmissionCount": 3/minSubmissionCount": 1/g' "$configdir"/*.json
fi

# XXX race conditions between build stages
await_agd_startable() {
local retries="$1"

local wait="10s"

if agd status >/dev/null 2>&1; then
# agd is running
if [[ $retries -gt 0 ]]; then
echo "Waiting $wait for agd to stop"
sleep $wait

await_agd_startable $((retries - 1))
else
echo "Cannot start agd because it's already running"
return 1
fi
fi
}

startAgd() {
echo "startAgd()"

# XXX debugging https://github.com/Agoric/agoric-3-proposals/issues/93
apt install net-tools
netstat
# precondition check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#127 (comment)

Suggested change
# precondition check
# XXX debugging https://github.com/Agoric/agoric-3-proposals/issues/93
apt install net-tools
netstat -plnA inet
# precondition check

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is to remove the netstat debugging. The underlying cause is that agd is already bound to the ports. I don't know the cause of that but this hacks around it by waiting for it to die.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I'm trying to get to the bottom of that with a more useful invocation of netstat.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I thought you were suggesting a change in this PR. If you want to figure out the cause of failures in #127 I thought you'd push to that branch whatever logging you need.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm putting this up for review again because I think we should keep those netstat logs out of main. They make the logs unwieldy to scroll in the Github UI

await_agd_startable 10

agd start --log_level warn "$@" &
AGD_PID=$!
Expand Down