Error in readFully method from client-utils: Rejected promise with missing vStorage data

[Jorge-Lopes]

Describe the bug

After the changes introduced to the client-utils package in PR #10566, the readFully method from the Agoric client-utils package fails when attempting to read a vstorage node. Instead of returning the expected value, it produces a rejected promise with the following error message:

  Rejected promise returned by test. Reason:

  Error {
    code: 38,
    codespace: 'sdk',
    message: 'error code 38 reading data of published.committees.Economic_Committee.latestQuestion: no data for vstorage path: not found',
  }

To Reproduce

Steps to reproduce the behavior:

1. Go to Draft PR Jorge/10574 read fully #10575
2. Go to the CI action test-docker-build
3. See error message

Expected behavior

The readFully method should correctly return the values stored in a specific node, recorded after a given block height.

Platform Environment

OS: macOS Sequoia v15.0.1
Node.js: v20.9.0
Agoric-SDK: agoric-upgrade-16av-1172-g3de052bbe8

[Jorge-Lopes]

cc: @Chris-Hibbert

[turadg]

After the changes introduced to the client-utils package in PR #10566, the readFully method from the Agoric client-utils package fails when attempting to read a vstorage node

I can't tell whether you're attributing the cause of this problem to #10566. Are you saying that it worked before? (i.e. Are you saying "Even after the changes…" or "Because of the changes…")

[Jorge-Lopes]

I can't tell whether you're attributing the cause of this problem to #10566. Are you saying that it worked before? (i.e. Are you saying "Even after the changes…" or "Because of the changes…")

I am saying "Even after the changes…".
Sorry for the lack of clarity in the description.

[dckc]

readFully is a sort of awkward API - it lumps the results of a sequence of queries into one array, and changes in the way cosmos-sdk reports the end of the available data have made it somewhat unstable (#9024 etc.).

I hope we can migrate toward something like readHistory that provides an async iterator. If the tail end of the iterator is flaky, at least the iterations before that are useful.