fix: fix incorrect use of model_validate_json #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtyoung84
reviewed
Feb 4, 2025
jtyoung84
reviewed
Feb 4, 2025
jtyoung84
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where dictionaries were being passed to
model_validate_json(which accepts a string) instead ofmodel_validate.Because some of the core files have model validators that run in "after" mode and depend on the model being an object and not a dictionary, this bug was causing attempts to validate a (valid) file using
Metadata.model_validate()to fail. Using the core file directly, i.e.Rig.model_validate()always worked.The bug was causing user warnings which no longer exist, so I had to remove some test assertions, I checked w/ Helen that these aren't important.
I also added two print statements so that these kinds of errors can be caught by users/developers. It was very confusing to debug this because the errors were being hidden.