Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TarsVirusIdentifiers.plasmid_tars_alias a list #1262

Closed
7 tasks
mekhlakapoor opened this issue Feb 7, 2025 · 1 comment · Fixed by #1301
Closed
7 tasks

Make TarsVirusIdentifiers.plasmid_tars_alias a list #1262

mekhlakapoor opened this issue Feb 7, 2025 · 1 comment · Fixed by #1301
Assignees
@dbirman
Labels
feature New feature
Milestone
data-schema 2.0

Comments

@mekhlakapoor
Copy link
Contributor

User story

In TARS, it is possible for a virus to have multiple molecules, and therefore have multiple plasmid aliases.

Acceptance criteria

  • Make TarsVirusIdentifiers.plasmid_tars_alias a list

Sprint Ready Checklist

  • 1. Acceptance criteria defined
  • 2. Team understands acceptance criteria
  • 3. Team has defined solution / steps to satisfy acceptance criteria
  • 4. Acceptance criteria is verifiable / testable
  • 5. External / 3rd Party dependencies identified
  • 6. Ticket is prioritized and sized

Notes

Add any helpful notes here.
@dyf
Copy link
Member

dyf commented Feb 11, 2025 •
edited
Loading

Do this in a backwards compatible way I think? Union[str,List[str]]

@dbirman dbirman added the feature New feature label Feb 16, 2025
@dbirman dbirman self-assigned this Mar 5, 2025
@dbirman dbirman linked a pull request Mar 5, 2025 that will close this issue
1262 make tarsvirusidentifiersplasmid tars alias a list #1301
Merged
@dbirman dbirman closed this as completed Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbirman dbirman

Labels
feature New feature
Projects
None yet
Milestone
data-schema 2.0
Development

Successfully merging a pull request may close this issue.

1262 make tarsvirusidentifiersplasmid tars alias a list AllenNeuralDynamics/aind-data-schema
3 participants
@dyf @dbirman @mekhlakapoor