Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure unique datapoint ids #12

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Ensure unique datapoint ids #12

merged 2 commits into from
Aug 23, 2023

Conversation

jvansanten
Copy link
Contributor

Quoth @wombaugh:

I have encountered an issue of my own when parsing the distributed elasticc2 alerts: Among these, the dieSourceID which we use to identifiy datapoints can in very rare cases be duplicates of the diaObjectId which is used to identify transients. This affects us since we use the diaObjectId as id when storing a special dp with e.g. redshift information.

Avoid (almost all) id collisions by using the hash of the body as the datapoint id. This is analogous to AmpelAstro/Ampel-ZTF#60, and has the same weaknesses. Since we don't use any information encoded in diaObjectId/diaSourceId (if it exists), this should be a minimal change.

@jvansanten jvansanten merged commit bf7a25e into main Aug 23, 2023
@jvansanten jvansanten deleted the hash-datapoints branch August 23, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants