Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended requirejs-config.js files don't seem to get detected, but not entirely sure if they should? #3

Open
hostep opened this issue Dec 5, 2018 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@hostep
Copy link
Contributor

hostep commented Dec 5, 2018

This happens both on the master and fix-template-detection-issue-1 branches.
Tested when comparing Magento 2.2.0 to 2.2.7

I'm not sure how important it is to report this, because I don't think you should mess with the default contents of these files, since it's supposed to be extended, but maybe people actually do overrides in these files.

So, if you have the following file in your frontend theme: app/design/frontend/Vendor/theme/Magento_Catalog/requirejs-config.js, it gets merged with vendor/magento/module-catalog/view/frontend/requirejs-config.js I think.

Right now this isn't reported, but I'm not entirely sure if it should be reported, it could be that just any requirejs-config.js files are all merged together and it probably doesn't matter in what modules they live. So not sure if it should get reported?

Update: I just saw in the code that this is actually still under investigation

@convenient convenient added the help wanted Extra attention is needed label Jan 29, 2019
@tr33m4n
Copy link
Contributor

tr33m4n commented Feb 9, 2024

Hey @hostep, I'm going to try and be a bit more active on Ampersands public repos and try and sort through the backlog. Is this still an issue? Thanks

@hostep
Copy link
Contributor Author

hostep commented Nov 6, 2024

Sorry for the long delay. I guess it's probably fine to not warn about changes to this requireje-config.js file. I haven't encountered this particular case in the last few years, but I'm not a frontend developer, so it's hard to say for me.
If we want to know for certain, we probably should ask feedback to frontend developers to see how they handle this file and if they would be interested in being notified about changes to this file in a Magento upgrade...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants