You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This happens both on the master and fix-template-detection-issue-1 branches.
Tested when comparing Magento 2.2.0 to 2.2.7
I'm not sure how important it is to report this, because I don't think you should mess with the default contents of these files, since it's supposed to be extended, but maybe people actually do overrides in these files.
So, if you have the following file in your frontend theme: app/design/frontend/Vendor/theme/Magento_Catalog/requirejs-config.js, it gets merged with vendor/magento/module-catalog/view/frontend/requirejs-config.js I think.
Right now this isn't reported, but I'm not entirely sure if it should be reported, it could be that just any requirejs-config.js files are all merged together and it probably doesn't matter in what modules they live. So not sure if it should get reported?
Sorry for the long delay. I guess it's probably fine to not warn about changes to this requireje-config.js file. I haven't encountered this particular case in the last few years, but I'm not a frontend developer, so it's hard to say for me.
If we want to know for certain, we probably should ask feedback to frontend developers to see how they handle this file and if they would be interested in being notified about changes to this file in a Magento upgrade...
This happens both on the
master
andfix-template-detection-issue-1
branches.Tested when comparing Magento 2.2.0 to 2.2.7
I'm not sure how important it is to report this, because I don't think you should mess with the default contents of these files, since it's supposed to be extended, but maybe people actually do overrides in these files.
So, if you have the following file in your frontend theme:
app/design/frontend/Vendor/theme/Magento_Catalog/requirejs-config.js
, it gets merged withvendor/magento/module-catalog/view/frontend/requirejs-config.js
I think.Right now this isn't reported, but I'm not entirely sure if it should be reported, it could be that just any
requirejs-config.js
files are all merged together and it probably doesn't matter in what modules they live. So not sure if it should get reported?Update: I just saw in the code that this is actually still under investigation
The text was updated successfully, but these errors were encountered: