Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event API Change #3

Open
chrisaxiom opened this issue Sep 14, 2017 · 0 comments
Open

Event API Change #3

chrisaxiom opened this issue Sep 14, 2017 · 0 comments

Comments

@chrisaxiom
Copy link

chrisaxiom commented Sep 14, 2017 •
edited
Loading

I think the call to func (e *Event) Write(p []byte) (int, error) { should not convert to a string; it should just do what WriteRaw does, and then remove WriteRaw. Having it actually convert to a string and do all the checks is not the expected behaviour (the caller has WriteString for that purpose).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrisaxiom