Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata in exports to identify author, original ShaderFrog URL, version. #11

Closed
bhouston opened this issue Aug 18, 2015 · 4 comments
Closed

Comments

@bhouston
Copy link

The following would be really useful metadata in each export:

Author username (thus able to get ShaderFrog profile url)
ShaderFrog URL to shader, or enough data that one can reconstruct it, like a shader ID.
Revision of the shader on ShaderFrog (because there will be a lot of different versions flying around.)

@bhouston
Copy link
Author

The reason I ask if that if we import a ShaderFrog resource into Clara, it would be nice to have the ability to fork or see it on ShaderFrog with just a click -- this data would make that possible.

@AndrewRayCode
Copy link
Owner

good idea. i'm thinking export the id and username, and give the runtime the ability to get the url with runtime.getShaderFrogLink( shaderId ) or something like that - that way if the URLs ever changed they won't be hard coded into json, and the latest version of the runtime will generate them correctly. what do you think?

I think revisions should be a separate issue, since it entails a bit more work independent of the exported format. edit: you're 2 years ahead of me #12

@bhouston
Copy link
Author

Username and Shader ID is minimally sufficient.

If you do not have revision numbers, it may be useful to just add a date/time of export.

Maybe you want to include a format version number of the JSON somewhere so that when you make breaking changes there is a way to detect it.

@AndrewRayCode
Copy link
Owner

ok, I added a url field to the shader that links to the full url, and a user object that has username and url. http://shaderfrog.com/api/download?shaderId=123&preview=1 I'll add revision to the file as part of the revision ticket work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants