Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Importer from ShaderToy is broken? #18

Open
SkysoulDesign opened this issue Jan 19, 2016 · 4 comments
Open

The Importer from ShaderToy is broken? #18

SkysoulDesign opened this issue Jan 19, 2016 · 4 comments

Comments

@SkysoulDesign
Copy link

i couldnt never get any shadertoy project to work, neither importing nor pasting if import fail or that Public + Api is not set...

for instanse i get straight way this error on the console when i try to import:

http://shaderfrog.com/api/importFromShaderToy?url=https:%2F%2Fwww.shadertoy.com%2Fview%2Flsy3Rh 400 (Bad Request)

by pasting this url: https://www.shadertoy.com/view/lsy3Rh

if i am to wait long enough i get the screen past the code here screen.. which also doesnt work..

@AndrewRayCode
Copy link
Owner

The importer has a few problem cases unfortunately that cause it not to be able to parse all ShaderToy code (it's an ongoing process).

I was able to get the import to work by pasting in the code. I had to modify the time line after import which is a case I hadn't accounted for: http://shaderfrog.com/app/view/483

@SkysoulDesign
Copy link
Author

after your successfully import, i tried in different browsers... and i found out that by pasting the code on Chrome Version 47.0.2526.111 m it wasnt working.. but in the Chrome Version 49.0.2623.5 canary (64-bit) it did work... i guess it might have some browser version issues... and thank you.. i found your tool is really amazing! i was so frustrated i couldnt find nothing like this before... once i wished to santa i could get a shaderforge like app for threejs and yeah u made it !!!

@AndrewRayCode
Copy link
Owner

I'll investigate Chrome vs canary. The actual conversion happens on the server side but there may be a UI issue. Historically Canary / Firefox dev build have some odd behaviors, so it's strange that canary worked this time. Unfortunately there will still be some ShaderToy shaders that just won't import period due to their code using "interesting" glsl features that my parser can't handle (yet).

And thank you! Just FYI I'm taking a small hiatus from Shader Frog, until February. Then I plan to go back and add a lot of missing features, tutorials, and streamline the interface a bit. If you have any suggestions I would appreciate if you'd consider filing bugs for them, at this point any user feedback I collect is

@tadaskarpavicius
Copy link

Hi, has this been fixed? I am unable to import anything from shadertoy. Keep getting this message:
This shader does not have the "Public + API" settings enabled in ShaderToy. You can try pasting in the source code below.

And I am pretty sure I have set my shader to Public + API...

Copying source code does not work either. I get
Sorry, something went wrong importing this ShaderToy shader. It is currently unavailable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants