Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for docker with root user #43

Open
Kopf02 opened this issue Jul 27, 2023 · 2 comments
Open

Add Support for docker with root user #43

Kopf02 opened this issue Jul 27, 2023 · 2 comments

Comments

@Kopf02
Copy link

Kopf02 commented Jul 27, 2023

Would be really nice to see images that don't have the user set to node.
I'm currently doing firebase deployments from gitlab-ci and the install of firebase-tools each times takes to long so i tought i could use your image. Unfortunately gitlab mounts the project files as root, so i cant deploy using this image, since I don't have access to the folder. GitLab runner don't have the option of override the user.

Since this image is really well maintaned, it would be nice to add this feature to the project instead of relying on an own image.

Thanks in advance!

@yinzara
Copy link

yinzara commented Aug 18, 2023

This would be super useful for me. Right now I have a dockerfile that's literally:

FROM andreysenov/firebase-tools:12.4.8-node-18-slim
USER root

that I have to build as part of my build process then use it immediately.

@yinzara
Copy link

yinzara commented Aug 18, 2023

Would be really nice to see images that don't have the user set to node. I'm currently doing firebase deployments from gitlab-ci and the install of firebase-tools each times takes to long so i tought i could use your image. Unfortunately gitlab mounts the project files as root, so i cant deploy using this image, since I don't have access to the folder. GitLab runner don't have the option of override the user.

Since this image is really well maintaned, it would be nice to add this feature to the project instead of relying on an own image.

Thanks in advance!

You can actually get around this in GitLab as well.

Just use the above Dockerfile I gave (change the version tag for firebase-tools to match what you need) and have two steps at the start of your build that runs a docker build -t my-repo-base/firebase-tools:latest and docker push my-repo-base/firebase-tools:latest then the later steps of the build just use the image "repo-base/firebse-tools:latest"

Where repo-base is whatever you use as your container base registry

yinzara added a commit to yinzara/firebase-tools-docker that referenced this issue Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants