Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip unknown tags #209

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Skip unknown tags #209

wants to merge 3 commits into from

Conversation

TerjeLon
Copy link

Should resolve #202.

Identified two possibilities as to why this may occur:

Trying to read a non-supported (Unknown) datagroup.

I am struggling to see how this could even be possible as COM parse function already filters these out:

for v in vals {
    if let index = DataGroupParser.tags.firstIndex(of: v) {
        dataGroupsPresent.append( DataGroupParser.dataGroupNames[index] )
    }
}

Regardless, in such a scenario the reading should not fail, but just skip the datagroup and carry on. So i added a safeguard where this should now be the behaviour going forwards.

COM and/or SOD is listed in COM

DataGroupParser lists COM as "Common" and SOD as "SecurityData". This would result in either of them being added as Unknown in COM.dataGroupsPresent. I believe this to be most likely the scenario that occurs in #202.

Now COM and SOD will be added correctly

Other changes

  • Ignoring some workspace configuration files
  • Moved tests from Examples to the actual Package so they can be ran without needing to setup the Example project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails on chinese passport
1 participant