Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve #202.
Identified two possibilities as to why this may occur:
Trying to read a non-supported (Unknown) datagroup.
I am struggling to see how this could even be possible as COM parse function already filters these out:
Regardless, in such a scenario the reading should not fail, but just skip the datagroup and carry on. So i added a safeguard where this should now be the behaviour going forwards.
COM and/or SOD is listed in COM
DataGroupParser lists COM as "Common" and SOD as "SecurityData". This would result in either of them being added as Unknown in
COM.dataGroupsPresent
. I believe this to be most likely the scenario that occurs in #202.Now COM and SOD will be added correctly
Other changes