Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets from node_modules not included #21

Open
kenmadev opened this issue Jan 15, 2025 · 1 comment
Open

Assets from node_modules not included #21

kenmadev opened this issue Jan 15, 2025 · 1 comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed

Comments

@kenmadev
Copy link

kenmadev commented Jan 15, 2025

Describe the bug
Assets bundling works fine in v2.x.x Because I have this json prop on my package.json

"pkg": {
    "assets": [
      "node_modules/header-generator/data_files/**/*"
    ],
  }

and since the old pkg was able to read it, it worked just fine.
I think in v3.x.x the assets are not included properly into the bundled .exe. I'm getting ENOENT to the required files.

To Reproduce
Install npm package header-generator. This package contains data_files assets folder that is required to function.

Expected behavior
Assets should be able to be included in the bundled .exe file and do its normal behaviour

@kenmadev kenmadev added the bug Something isn't working label Jan 15, 2025
@AngaBlue
Copy link
Owner

Hey @kenmadev , thanks for the report. It looks like replacing this same functionality as seen in pkg would involve creating a virtual file system as laid out in this issue. I don't believe I will have the bandwidth to fix this in the immediate future. Until I either find the time or a PR is submitted, I recommend using v2.x.x.

@AngaBlue AngaBlue added enhancement New feature or request help wanted Extra attention is needed labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants