Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code style and code organization #4

Open
splincode opened this issue Mar 1, 2018 · 4 comments
Open

Add code style and code organization #4

splincode opened this issue Mar 1, 2018 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@splincode
Copy link
Member

splincode commented Mar 1, 2018

  1. Add tslint.json
  2. Add travis CI
  3. Add codecoverage
  4. Add contributing.md+ precommit hooks
  5. Add changelog generator
@splincode splincode changed the title Add tslint.json Add code style and code organization Mar 1, 2018
@obenjiro
Copy link
Contributor

Should we close this issue?

@splincode
Copy link
Member Author

There are 3 more things left to do

  1. Add codecoverage
  2. Add contributing.md+ precommit hooks
  3. Add changelog generator

@splincode splincode added enhancement New feature or request help wanted Extra attention is needed labels Jul 24, 2018
@tplk
Copy link
Contributor

tplk commented Aug 2, 2018

To generate reasonable changelogs it's better to enforce commit message format.
I'd suggest conventional-changelog which is based on angular's commit msg format.

@tplk
Copy link
Contributor

tplk commented Aug 2, 2018

@splincode also you should update issue message to represent progress.

~1. Add tslint.json~
~2. Add travis CI~
3. Add codecoverage
4. Add contributing.md+ precommit hooks
5. Add changelog generator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants