Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: finish testing proxies #760

Open
7 of 18 tasks
fubuloubu opened this issue May 29, 2022 · 3 comments · May be fixed by #2467
Open
7 of 18 tasks

test: finish testing proxies #760

fubuloubu opened this issue May 29, 2022 · 3 comments · May be fixed by #2467
Labels
category: docs Improvements or additions to documentation category: testing Test plan for an existing feature good first issue Good for newcomers help wanted Extra attention is needed size: 2 pieces Relatively easy, but requires some thought

Comments

@fubuloubu
Copy link
Member

fubuloubu commented May 29, 2022 •
edited by antazoey
Loading

Finish testing proxies. The first 3 were tested in #1507 , now we must add tests for the remaining.

More were added via #2400

Proxies to test!

  • Minimal
  • Standard
  • Beacon
  • UUPS
  • Vyper
  • VyperBeta
  • Clones
  • GnosisSafe
  • OpenZeppelin
  • Delegate
  • ZeroAge
  • CWIA
  • OldCWIA
  • SoladyPush0
  • SoladyCWIA
  • SudoswapCWIA
  • SplitsCWIA
  • Sequence
@fubuloubu fubuloubu added category: docs Improvements or additions to documentation category: feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed size: 2 pieces Relatively easy, but requires some thought category: testing Test plan for an existing feature and removed category: feature New feature or request labels May 29, 2022
@antazoey antazoey mentioned this issue Jun 28, 2023
Merged
3 tasks
@antazoey
Copy link
Member

ok thoughts on not adding tests for every single proxy and just adding them as needed? I tested the first 3 but am exhausted already, even though it helped me find all sorts of other bugs

@fubuloubu
Copy link
Member Author

We got a good start more tests = better, but don't have to do them all right away

Let's leave this issue open until it's complete though

@antazoey antazoey changed the title Add docs and tests for proxy support feature test: finish testing proxies Jun 29, 2023
@antazoey
Copy link
Member

I updated the title and description to reflect that it is only to finish testing the proxies now.

@0xthedance 0xthedance mentioned this issue Dec 9, 2024
Merged
3 tasks
@0xthedance 0xthedance linked a pull request Jan 13, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: docs Improvements or additions to documentation category: testing Test plan for an existing feature good first issue Good for newcomers help wanted Extra attention is needed size: 2 pieces Relatively easy, but requires some thought
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: tests for nine more proxies 0xthedance/ape
2 participants
@fubuloubu @antazoey