New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why using raw ptr for detector instead of smart ptr? #15646

Open

ryanyej opened this issue Feb 13, 2025 · 1 comment

ryanyej commented Feb 13, 2025

As title, i am wondering why using raw ptr for detector instead of shared_ptr

For example:
bool Detect(const LidarDetectorOptions& options, LidarFrame* frame) override;
why using LidarFrame* ,not shared_ptr ?

waiting for your back.

Contributor

hearto1314 commented Feb 17, 2025

Hi, it can be defined as shared_ptr, a lidar_frame_.get() is passed in this implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment