Async demo 09: Never stops after running 14+ requests

[kabua]

After running the demo a few times and allowing it to run for several request, 14+ times), the screen fills up with

Object name: 'System.Net.Http.HttpClient'.

The exception happens on line 159.

[martincostello]

Looks like when the loop ends by the CancellationToken being fired and the HttpClient is disposed of:

Polly-Samples/PollyDemos/Async/AsyncDemo09_Wrap-Fallback-Timeout-WaitAndRetry.cs

Line 144 in 88c3b8e

using (var client = new HttpClient())

If there are any cancelled HTTP requests still pending to run, they'll try to use the now-disposed HttpClient, causing an ObjectDisposedException:

Polly-Samples/PollyDemos/Async/AsyncDemo09_Wrap-Fallback-Timeout-WaitAndRetry.cs

Line 159 in 88c3b8e

client.GetStringAsync(Configuration.WEB_API_ROOT + "/api/values/" + totalRequests),

[kabua]

Yes, that is correct.

However, the policy is configured to handle all exceptions and to run forever, and the policyWrap.ExecuteAsync() is accepting a cancellationToken but which appears not to be honoring.

Also, how would I write something like, handle all exceptions except for MyException? Something like:
Policy.Handle<Exception>().ButNot<MyException>()...

Thanks.

[martincostello]

@peter-csala Something to consider when you get to migrating this demo.

[peter-csala]

@martincostello Please assign to me, otherwise I will forget it :)

[peter-csala]

After the V8 migration I can not reproduce the problem. The application can be stopped any time.

@martincostello I think we can close this issue if you agree.