circuitBreakerStrategy never opens

[warren-pieterse]

In the Demo06_WaitAndRetryNestingCircuitBreaker the only message logged is "Strategy logging: ...". the "circuit breaker strategy: break if the action fails at least 4 times in a row" never happens?

Am I missing something?

[martincostello]

FYI @peter-csala

[peter-csala]

Let me check it. @martincostello Please assign to me

[peter-csala]

I've found the issue. :)

The FailureRatio was set to 1.0, that means all requests should fail during the sampling period.
But I've forget to set the SamplingDuration that's why it used the default value which is 30 seconds.

After setting the SamplingDuration to 2 seconds then the CB breaks nicely:

I'll file a PR with a fix shortly.