Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discussion about getting rid of the sync demos #64

Closed
peter-csala opened this issue Oct 13, 2023 · 2 comments
Closed

Discussion about getting rid of the sync demos #64

peter-csala opened this issue Oct 13, 2023 · 2 comments

Comments

@peter-csala
Copy link
Contributor

I'm proposing to get rid of the sync demos. Here is my rationale:

  • Prior V8 you have to define separate policies for sync and async methods
  • Since V8 you have a unified strategy which can be executed both in sync and in async way
  • After the V8 migration the sync demos look like code-duplicates rather than great additions

Is there any objection to delete the sync demos?
@peter-csala
Copy link
Contributor Author

@martincostello , @joelhulen

@martincostello
Copy link
Member

I vote 🔥🗑️

@peter-csala peter-csala mentioned this issue Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martincostello @peter-csala