Skip to content

Commit 3b808d0

Browse files
authored
Merge pull request #336 from AppDevNext/SomeRendererKotlin
Some renderer in Kotlin
2 parents 9dd55ea + 567b7cb commit 3b808d0

File tree

8 files changed

+1439
-1502
lines changed

8 files changed

+1439
-1502
lines changed

MPChartLib/src/main/java/com/github/mikephil/charting/renderer/BarChartRenderer.java

Lines changed: 0 additions & 553 deletions
This file was deleted.

MPChartLib/src/main/java/com/github/mikephil/charting/renderer/BarChartRenderer.kt

Lines changed: 560 additions & 0 deletions
Large diffs are not rendered by default.

MPChartLib/src/main/java/com/github/mikephil/charting/renderer/CombinedChartRenderer.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
import com.github.mikephil.charting.data.ChartData;
1010
import com.github.mikephil.charting.data.CombinedData;
1111
import com.github.mikephil.charting.highlight.Highlight;
12-
import com.github.mikephil.charting.interfaces.dataprovider.BarLineScatterCandleBubbleDataProvider;
1312
import com.github.mikephil.charting.utils.ViewPortHandler;
1413

1514
import java.lang.ref.WeakReference;
@@ -115,9 +114,9 @@ public void drawHighlighted(Canvas c, Highlight[] indices) {
115114
ChartData data = null;
116115

117116
if (renderer instanceof BarChartRenderer)
118-
data = ((BarChartRenderer)renderer).mChart.getBarData();
117+
data = ((BarChartRenderer)renderer).chart.getBarData();
119118
else if (renderer instanceof LineChartRenderer)
120-
data = ((LineChartRenderer)renderer).mChart.getLineData();
119+
data = ((LineChartRenderer)renderer).chart.getLineData();
121120
else if (renderer instanceof CandleStickChartRenderer)
122121
data = ((CandleStickChartRenderer)renderer).mChart.getCandleData();
123122
else if (renderer instanceof ScatterChartRenderer)

MPChartLib/src/main/java/com/github/mikephil/charting/renderer/HorizontalBarChartRenderer.java

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,12 @@ public HorizontalBarChartRenderer(BarDataProvider chart, ChartAnimator animator,
4141
@Override
4242
public void initBuffers() {
4343

44-
BarData barData = mChart.getBarData();
45-
mBarBuffers = new HorizontalBarBuffer[barData.getDataSetCount()];
44+
BarData barData = chart.getBarData();
45+
barBuffers = new HorizontalBarBuffer[barData.getDataSetCount()];
4646

47-
for (int i = 0; i < mBarBuffers.length; i++) {
47+
for (int i = 0; i < barBuffers.length; i++) {
4848
IBarDataSet set = barData.getDataSetByIndex(i);
49-
mBarBuffers[i] = new HorizontalBarBuffer(set.getEntryCount() * 4 * (set.isStacked() ? set.getStackSize() : 1),
49+
barBuffers[i] = new HorizontalBarBuffer(set.getEntryCount() * 4 * (set.isStacked() ? set.getStackSize() : 1),
5050
barData.getDataSetCount(), set.isStacked());
5151
}
5252
}
@@ -56,21 +56,21 @@ public void initBuffers() {
5656
@Override
5757
protected void drawDataSet(Canvas c, IBarDataSet dataSet, int index) {
5858

59-
Transformer trans = mChart.getTransformer(dataSet.getAxisDependency());
59+
Transformer trans = chart.getTransformer(dataSet.getAxisDependency());
6060

61-
mBarBorderPaint.setColor(dataSet.getBarBorderColor());
62-
mBarBorderPaint.setStrokeWidth(Utils.convertDpToPixel(dataSet.getBarBorderWidth()));
61+
barBorderPaint.setColor(dataSet.getBarBorderColor());
62+
barBorderPaint.setStrokeWidth(Utils.convertDpToPixel(dataSet.getBarBorderWidth()));
6363

6464
final boolean drawBorder = dataSet.getBarBorderWidth() > 0.f;
6565

6666
float phaseX = mAnimator.getPhaseX();
6767
float phaseY = mAnimator.getPhaseY();
6868

6969
// draw the bar shadow before the values
70-
if (mChart.isDrawBarShadowEnabled()) {
71-
mShadowPaint.setColor(dataSet.getBarShadowColor());
70+
if (chart.isDrawBarShadowEnabled()) {
71+
shadowPaint.setColor(dataSet.getBarShadowColor());
7272

73-
BarData barData = mChart.getBarData();
73+
BarData barData = chart.getBarData();
7474

7575
final float barWidth = barData.getBarWidth();
7676
final float barWidthHalf = barWidth / 2.0f;
@@ -100,24 +100,24 @@ protected void drawDataSet(Canvas c, IBarDataSet dataSet, int index) {
100100
mBarShadowRectBuffer.left = mViewPortHandler.contentLeft();
101101
mBarShadowRectBuffer.right = mViewPortHandler.contentRight();
102102

103-
c.drawRect(mBarShadowRectBuffer, mShadowPaint);
103+
c.drawRect(mBarShadowRectBuffer, shadowPaint);
104104
}
105105
}
106106

107107
// initialize the buffer
108-
BarBuffer buffer = mBarBuffers[index];
108+
BarBuffer buffer = barBuffers[index];
109109
buffer.setPhases(phaseX, phaseY);
110110
buffer.setDataSet(index);
111-
buffer.setInverted(mChart.isInverted(dataSet.getAxisDependency()));
112-
buffer.setBarWidth(mChart.getBarData().getBarWidth());
111+
buffer.setInverted(chart.isInverted(dataSet.getAxisDependency()));
112+
buffer.setBarWidth(chart.getBarData().getBarWidth());
113113

114114
buffer.feed(dataSet);
115115

116116
trans.pointValuesToPixel(buffer.buffer);
117117

118118
final boolean isCustomFill = dataSet.getFills() != null && !dataSet.getFills().isEmpty();
119119
final boolean isSingleColor = dataSet.getColors().size() == 1;
120-
final boolean isInverted = mChart.isInverted(dataSet.getAxisDependency());
120+
final boolean isInverted = chart.isInverted(dataSet.getAxisDependency());
121121

122122
if (isSingleColor) {
123123
mRenderPaint.setColor(dataSet.getColor());
@@ -156,24 +156,24 @@ protected void drawDataSet(Canvas c, IBarDataSet dataSet, int index) {
156156

157157
if (drawBorder) {
158158
c.drawRect(buffer.buffer[j], buffer.buffer[j + 1], buffer.buffer[j + 2],
159-
buffer.buffer[j + 3], mBarBorderPaint);
159+
buffer.buffer[j + 3], barBorderPaint);
160160
}
161161
}
162162
}
163163

164164
@Override
165165
public void drawValues(Canvas c) {
166166
// if values are drawn
167-
if (isDrawingValuesAllowed(mChart)) {
167+
if (isDrawingValuesAllowed(chart)) {
168168

169-
List<IBarDataSet> dataSets = mChart.getBarData().getDataSets();
169+
List<IBarDataSet> dataSets = chart.getBarData().getDataSets();
170170

171171
final float valueOffsetPlus = Utils.convertDpToPixel(5f);
172172
float posOffset = 0f;
173173
float negOffset = 0f;
174-
final boolean drawValueAboveBar = mChart.isDrawValueAboveBarEnabled();
174+
final boolean drawValueAboveBar = chart.isDrawValueAboveBarEnabled();
175175

176-
for (int i = 0; i < mChart.getBarData().getDataSetCount(); i++) {
176+
for (int i = 0; i < chart.getBarData().getDataSetCount(); i++) {
177177

178178
IBarDataSet dataSet = dataSets.get(i);
179179
if (dataSet.getEntryCount() == 0) {
@@ -183,7 +183,7 @@ public void drawValues(Canvas c) {
183183
continue;
184184
}
185185

186-
boolean isInverted = mChart.isInverted(dataSet.getAxisDependency());
186+
boolean isInverted = chart.isInverted(dataSet.getAxisDependency());
187187

188188
// apply the text-styling defined by the DataSet
189189
applyValueTextStyle(dataSet);
@@ -192,7 +192,7 @@ public void drawValues(Canvas c) {
192192
IValueFormatter formatter = dataSet.getValueFormatter();
193193

194194
// get the buffer
195-
BarBuffer buffer = mBarBuffers[i];
195+
BarBuffer buffer = barBuffers[i];
196196

197197
final float phaseY = mAnimator.getPhaseY();
198198

@@ -265,7 +265,7 @@ public void drawValues(Canvas c) {
265265
// if each value of a potential stack should be drawn
266266
} else {
267267

268-
Transformer trans = mChart.getTransformer(dataSet.getAxisDependency());
268+
Transformer trans = chart.getTransformer(dataSet.getAxisDependency());
269269

270270
int bufferIndex = 0;
271271
int index = 0;
@@ -441,9 +441,9 @@ protected void prepareBarHighlight(float x, float y1, float y2, float barWidthHa
441441
float left = y1;
442442
float right = y2;
443443

444-
mBarRect.set(left, top, right, bottom);
444+
barRect.set(left, top, right, bottom);
445445

446-
trans.rectToPixelPhaseHorizontal(mBarRect, mAnimator.getPhaseY());
446+
trans.rectToPixelPhaseHorizontal(barRect, mAnimator.getPhaseY());
447447
}
448448

449449
@Override

0 commit comments

Comments
 (0)