Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Launching the Text Client in nogui mode through the Launcher shows no response to input via CLI #4406

Closed
ChiefMilesEdgeworth opened this issue Dec 28, 2024 · 3 comments
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs.

Comments

@ChiefMilesEdgeworth
Copy link

What happened?

I launched the text client via the AppImage on Linux using this command:

 ./Applications/Archipelago_0.5.1_linux-x86_64_3988ad7cf6bbdcc779dfb96f4d360368.AppImage "Text Client" -- --nogui

The results were this:

 >> ./Applications/Archipelago_0.5.1_linux-x86_64_3988ad7cf6bbdcc779dfb96f4d360368.AppImage "Text Client" -- --nogui
Archipelago (0.5.1) logging initialized on Linux-6.1.119-1-MANJARO-x86_64-with-glibc2.40 running Python 3.11.9 (frozen)
Archipelago (0.5.1) logging initialized on Linux-6.1.119-1-MANJARO-x86_64-with-glibc2.40 running Python 3.11.9 (frozen)
Please connect to an Archipelago server.
/connect archipelago.gg:37891
/help


The text client was not responding to input on the console, and failed to show the initial help message that normally appears when launched in GUI mode.

I also tried this with the standalone text client like so:

:~/Dow/arc/Archipelago >> ./ArchipelagoTextClient --nogui
Archipelago (0.5.1) logging initialized on Linux-6.1.119-1-MANJARO-x86_64-with-glibc2.40 running Python 3.11.9 (frozen)
Please connect to an Archipelago server.
/help
/help
    Returns the help listing
....

/connect archipelago.gg:37891
Connecting to Archipelago server at ws://archipelago.gg:37891
Connecting to Archipelago server at wss://archipelago.gg:37891
Connected
--------------------------------
Room Information:
--------------------------------
Server protocol version: 0.5.1, generator version: 0.5.1, tags: AP, WebHost
Release permission: auto
Remaining permission: goal
Collect permission: auto
A !hint costs 10% of your total location count as points and you get 1 for each location checked. Use !hint for more information.
Enter slot name:

It appears to work fine when used as a standalone binary, but when run through the launcher there's some sort of disconnect. Either a failure to send things to the console in nogui mode, or some other failure that's not raising an exception.

What were the expected results?

Running the Text Client in nogui mode through the launcher should behave the same as running the Text Client as a standalone binary in nogui mode.

Software

Local generation

@ChiefMilesEdgeworth ChiefMilesEdgeworth changed the title Bug: Launching the Text Client in nogui mode through the Launcher shows weird behavior Bug: Launching the Text Client in nogui mode through the Launcher shows no response to input via CLI Dec 28, 2024
@ChiefMilesEdgeworth
Copy link
Author

Looking through the launcher, it looks like the text client is launched via

subprocess.run([*get_exe(component.script_name), *args])

I'm guessing this is as simple as passing stdin, stdout, and stderr through to that subprocess.

@remyjette
Copy link
Collaborator

#3633 and #4237 both aim to address this

@ScipioWright ScipioWright added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Jan 13, 2025
@qwint
Copy link
Collaborator

qwint commented Jan 28, 2025

fixed by #4237

@qwint qwint closed this as completed Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs.
Projects
None yet
Development

No branches or pull requests

4 participants