Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Icon for Amazon Luna #2335

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Cod3rQwerty
Copy link

No description provided.

@Donnnno
Copy link
Collaborator

Donnnno commented Nov 10, 2024

Hi, please follow our contribution guide carefully!
We need a line for the appfilter, and rename the icon to amazon_luna

@gewaleelek
Copy link
Contributor

From the request dashboard, the appfilter line is probably

<!-- Amazon Luna -->
<item component="ComponentInfo{com.amazon.spiderpork/com.amazon.spiderpork.activities.MainActivity}" drawable="amazon_luna"/>

@gewaleelek
Copy link
Contributor

Since this PR has been inactive for a while, may I take the files, adjust the icon and include it in my PR?

gewaleelek added a commit to gewaleelek/Arcticons that referenced this pull request Nov 30, 2024
@Cod3rQwerty
Copy link
Author

Hi, please follow our contribution guide carefully! We need a line for the appfilter, and rename the icon to amazon_luna

I've done all the above, using @gewaleelek 's appfilter line. Are there any problems still? Sorry for the late response 😅

@gewaleelek
Copy link
Contributor

I've already included the icon in #2372 earlier today (see ed0173a) though I'm ok with either being merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants