Skip to content

Commit

Permalink
Front: CI: rename workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
Arthi-chaud committed Aug 8, 2024
1 parent 0392e18 commit 46f9f2b
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
3 changes: 3 additions & 0 deletions .github/actions/cache-front/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ description: 'Cache for Front'
runs:
using: "composite"
steps:
- name: Add build dependencies to container
shell: sh
run: apk add --update --no-progress tar
- name: Cache
uses: actions/cache@v3
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/front.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: "Front (Vue)"
name: "Front"
on:
pull_request:
branches: [ main ]
Expand Down Expand Up @@ -54,7 +54,7 @@ jobs:
- uses: ./.github/actions/cache-front
- run: yarn
- name: Check format
run: yarn run prettier --check
run: yarn run prettier --check .
Lint:
if: ${{ needs.changes.outputs.front == 'true' && github.event_name == 'pull_request' }}
runs-on: ubuntu-latest
Expand Down
5 changes: 2 additions & 3 deletions front/composables/player/context.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import Hls from "hls.js";
import { API } from "~/api/api";
import type { File } from "~/models/domain/file";
import type { FileInfo } from "~/models/domain/file-info";
import { v4 as uuidv4 } from 'uuid';
import { v4 as uuidv4 } from "uuid";

const canBePlayedNatively = (info: FileInfo, videoRef: HTMLVideoElement) => {
const codec = info.mimeCodec;
Expand Down Expand Up @@ -69,8 +69,8 @@ export const usePlayerContext = (props: {
player.error?.code ==
MediaError.MEDIA_ERR_SRC_NOT_SUPPORTED
) {
console.log("Moving to transcoding");
playMode.value = "hls";
playHls();
}
console.error(error);
};
Expand All @@ -86,7 +86,6 @@ export const usePlayerContext = (props: {
player.onended = props.onEnd;
};
const playDirectVideo = () => {
console.log(canBePlayedNatively(i, player))
if (!canBePlayedNatively(i, player)) {
playMode.value = "hls";
playHls();
Expand Down

0 comments on commit 46f9f2b

Please sign in to comment.