Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[State] Presets with state chunk is not supported in our .FXB generator/parser #907

Open
2 of 4 tasks
p0nce opened this issue Feb 17, 2025 · 1 comment
Open
2 of 4 tasks

[State] Presets with state chunk is not supported in our .FXB generator/parser #907

p0nce opened this issue Feb 17, 2025 · 1 comment
Labels
Enhancement This issue is about a new feature rather than a bug. Low interest Importance of this issue seems questionable for the bottom-line..

Comments

@p0nce
Copy link
Collaborator

p0nce commented Feb 17, 2025 •
edited
Loading

  • Can parse .fxp with chunk and non-chunks in presetbank
  • V2 Dplug chunks necessitate the --state flag in presetbank.
  • Can create .fxb bank made of presets with state chunks
  • Can parse such .fxb even if we generated it with presetbank

For now: presets with empty state will work, as a workaround.
@p0nce p0nce added Enhancement This issue is about a new feature rather than a bug. Low interest Importance of this issue seems questionable for the bottom-line.. labels Feb 17, 2025
p0nce pushed a commit that referenced this issue Feb 17, 2025
Fix problem with Dplug V2 chunk not parsed by presetbank.
63c5d9c 
Now one can .fxb bank with binState .fxp, provided there is no actual state data. See Issue #907.
@p0nce
Copy link
Collaborator Author

p0nce commented Feb 20, 2025

Would be clearer to have a lib that abstract presets in the first place, instead of having this weird PresetBank that is always with a Client, that owns exactly one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement This issue is about a new feature rather than a bug. Low interest Importance of this issue seems questionable for the bottom-line..
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p0nce