You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
likely related, rounding issue on small amount: 0 orderfill on rinkeby with an earlier version
Proposed solution:
a) Use roundedDiv for both sellWei and tradedTokens calculation in _fillOrder. It's a solution for issue 2.
b) On fill increase the fill buy or sell amount if the leftover is smaller than a parameter. It would resolve all the above issues. Need to think over if there is any potential abuse of this rule.
The text was updated successfully, but these errors were encountered:
a) we will user roundedDiv so issue about point 2. should be resolved
b) we leave the issue of minimum amounts in backlog for the limited pilot. We will run some performance tests with 1000+ orders and check how the UI can handle. Depending on results and on how big issue is it during the limited pilot we have multiple ways to tackle it, eg: we can hide small amounts on UI, or easily release a new Exchange contract.
Multiple related issues:
exchange_fiddling
branchProposed solution:
a) Use
roundedDiv
for bothsellWei
andtradedTokens
calculation in_fillOrder
. It's a solution for issue 2.b) On fill increase the fill buy or sell amount if the leftover is smaller than a parameter. It would resolve all the above issues. Need to think over if there is any potential abuse of this rule.
The text was updated successfully, but these errors were encountered: