-
Notifications
You must be signed in to change notification settings - Fork 402
PHP 8.0 support #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Have you taken a look at the php-version-upgrade branch and this pull request? Updating generator to fix PHP74 related bug #395 |
Just tried switching to that branch with |
@mav2287 I believe it is the stricter type checks in PHP 8 |
That would make sense. I dropped a comment on the merge request for the person who made the 7.4 patch to see if they are doing an 8.0 patch. If they do hopefully it gets merged in as well. |
Have there been any updates on this? We've been holding off on upgrading to php8 because of this bug, but it is starting to create some problems for us. |
@skystebnicki have you tested @markonikolicdir PR as a fix for this? I am also in a similar position as this is the only package that is holding us back from PHP 8 |
Unfortunately we were unable to get it to work, even with the PR fix, but we didn't spend too much time testing that because it's pretty critical we have the official package tested and working in our production environment. |
Any update on this? Running into the same problem on 8.0. I'd love to use the fix here, but can't until it's official :( |
+1 for PHP 8 support. |
Been trying to upgrade our app to PHP 8 for the last few days and this library is one of my main issues. Decided to write a PHP script to patch the files so I wouldn't have to use a fork of the official library. If you are looking for a temporary solution until they either fix this issue or you migrate away from Authorize.net (recommended), this could work.
I tried to apply these changes to a private fork but all the composer dependencies are so old I couldn't update everything to run tests. |
Is anyone from Authorize.net even monitoring this repo? Maybe we're just screaming in the desert here. Seems like such a trivial fix to leave undone for so long. |
I just filed a ticket with their support to see if we can get some eyes on it. Note of businesses out there, if you publish a github repo, it's not a good look if you fail to respond to customers there. |
I posted the issue in the Authorize.net Developer Community forum under PHP 8 Support for AuthorizeNet/sdk-php. |
Looks like this was fixed in version 2.0.2 |
@kkeith-adg thanks for updating. All my tests are looking green now. |
I see there were issues with PHP 7.4 here #383, when running my tests against PHP 8.0 i also see the following:
The text was updated successfully, but these errors were encountered: