-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post and comment likes: make them fully block-based #41668
Comments
OpenAI suggested the following labels for this issue:
|
This issue could use some more labels, to help prioritize and categorize our work. Could you please add at least a |
Hey, Jarda! 👋🏼 🙂 I agree with the issue you are outlining above. Below I would like to add just a couple notes from the initial Like block project we worked on previously. I also need to mention up-front that it has been quite some time since I worked with the Like block and there might have been some recent developments in Jetpack that I might be missing.
Originally, we aimed to automatically replace the legacy Like button with the new Like block (if a site is using a block-based theme). Unfortunately, back then we run into technical limitations of the Blocks API (details can be found in the following discussions: pdDOJh-2JP-p2#comment-2175 & p7DVsv-jKP-p2#comment-48980). Since that was in 2023, I suspect there might have been some changes to the Blocks API in the meantime which may allow for easier way forward today.
Yes, it would be great if users could keep the Like column on the Posts page in WP Admin even with the legacy Like button disabled, not forcing the user to keep the old Like button in the post markup if they want to rely on the Like block only.
That's right. This is something we did not cover as a part of the project where the Like block was created (pdDOJh-2JP-p2). |
I think this shoudn't be a major blocker that completely stops the project. Even without the auto-replacement with hooks API, we can still make Likes fully compatible with a 100% block-based workflow:
|
Related Epic and discussion: #36382 |
Impacted plugin
Jetpack
What
Fully support Like and Comment Like blocks instead of the_content/comment_text filters
How
If you go to Jetpack Sharing settings, the "Sharing buttons" feature warns you that you're dealing with a legacy feature and that you should use the "Sharing Buttons" block.
The "Like buttons" feature doesn't show such a warning. But it should 🙂
When I enable the
likes
orcomment-likes
module/feature, two things happen:the_content
/the_excerpt
/comment_text
filters and adds the post/comment Like widget to the markup.There should be a possibility to:
Currently this is not possible: if I have "Like buttons" enabled and I add the "Like" block to my template, I will see the "Like" button twice. The "legacy" and "block-based" Likes don't work together well.
Additionally, the "Comment Like" block currently doesn't exist at all, it's a feature gap.
The text was updated successfully, but these errors were encountered: