Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost: Re-activating the plugin doesn't run modules activation #41718

Open
dilirity opened this issue Feb 11, 2025 · 2 comments
Open

Boost: Re-activating the plugin doesn't run modules activation #41718

dilirity opened this issue Feb 11, 2025 · 2 comments
Labels
[Experiment] AI labels added [Feature] Concat [Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. [Plugin] Boost A feature to speed up the site and improve performance.

Comments

@dilirity
Copy link
Member

If a user were to enable Concat JS, the module would setup some events. If the user were to then disable boost (they might be trying several performance plugins to compare), Boost will run a cleanup of the events. If they were to activate Boost again, events would not be scheduled again, as that only happens when toggling the module.

Deliverable

Ideally we want to run "activate" on all modules that are active when boost is reactivated (or something similar).

@dilirity dilirity changed the title Boost: Re-activating the plugin doesn't run modules setup Boost: Re-activating the plugin doesn't run modules activation Feb 11, 2025
@dilirity dilirity added the [Plugin] Boost A feature to speed up the site and improve performance. label Feb 11, 2025
@github-actions github-actions bot added [Boost Feature] Setup Prompt [Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. [Feature] Concat labels Feb 11, 2025
Copy link
Contributor

OpenAI suggested the following labels for this issue:

  • [Feature Group] Content Management: The issue relates to how content management plugins like Boost handle module activations and interactions with other features.
  • [Boost Feature] Setup Prompt: The title and body indicate a need for better initialization of modules when the Boost plugin is activated, aligning with setup functionality.
  • [Feature] Concat: The issue specifically mentions 'Concat JS', which indicates a concern with the Concat feature and its integration when Boost is reactivated.

Copy link
Contributor

This issue could use some more labels, to help prioritize and categorize our work. Could you please add at least a [Type], a [Feature], and a [Pri] label?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Experiment] AI labels added [Feature] Concat [Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. [Plugin] Boost A feature to speed up the site and improve performance.
Projects
None yet
Development

No branches or pull requests

1 participant